ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-server: error 501 on startRecording when 'openvidu.recording' false

pull/73/head
pabloFuente 2018-04-25 16:53:07 +02:00
parent 470da9adfc
commit ac09441c1d
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openvidu-server/src/main/java/io/openvidu/server/recording/ComposedRecordingService.java
View File

@ -78,7 +78,7 @@ public class ComposedRecordingService {
private static final Logger log = LoggerFactory.getLogger(ComposedRecordingService.class); private static final Logger log = LoggerFactory.getLogger(ComposedRecordingService.class);
@Autowired @Autowired
OpenviduConfig openviduConfig; private OpenviduConfig openviduConfig;
@Autowired @Autowired
private SessionEventsHandler sessionHandler; private SessionEventsHandler sessionHandler;

9
openvidu-server/src/main/java/io/openvidu/server/rest/SessionRestController.java
View File

@ -41,6 +41,7 @@ import io.openvidu.java.client.RecordingMode;
import io.openvidu.java.client.RecordingProperties; import io.openvidu.java.client.RecordingProperties;
import io.openvidu.java.client.MediaMode; import io.openvidu.java.client.MediaMode;
import io.openvidu.java.client.SessionProperties; import io.openvidu.java.client.SessionProperties;
import io.openvidu.server.config.OpenviduConfig;
import io.openvidu.server.core.ParticipantRole; import io.openvidu.server.core.ParticipantRole;
import io.openvidu.server.core.Session; import io.openvidu.server.core.Session;
import io.openvidu.server.core.SessionManager; import io.openvidu.server.core.SessionManager;
@ -62,6 +63,9 @@ public class SessionRestController {
@Autowired @Autowired
private ComposedRecordingService recordingService; private ComposedRecordingService recordingService;
@Autowired
private OpenviduConfig openviduConfig;
@RequestMapping(value = "/sessions", method = RequestMethod.GET) @RequestMapping(value = "/sessions", method = RequestMethod.GET)
public Set<String> getAllSessions() { public Set<String> getAllSessions() {
return sessionManager.getSessions(); return sessionManager.getSessions();
@ -166,6 +170,11 @@ public class SessionRestController {
return new ResponseEntity<JSONObject>(HttpStatus.BAD_REQUEST); return new ResponseEntity<JSONObject>(HttpStatus.BAD_REQUEST);
} }
if (!this.openviduConfig.isRecordingModuleEnabled()) {
// OpenVidu Server configuration property "openvidu.recording" is set to false
return new ResponseEntity<JSONObject>(HttpStatus.NOT_IMPLEMENTED);
}
Session session = sessionManager.getSession(sessionId); Session session = sessionManager.getSession(sessionId);
if (session == null) { if (session == null) {