From ac09441c1dee894b0463c3b6dc5c83f0720736f8 Mon Sep 17 00:00:00 2001 From: pabloFuente Date: Wed, 25 Apr 2018 16:53:07 +0200 Subject: [PATCH] openvidu-server: error 501 on startRecording when 'openvidu.recording' false --- .../server/recording/ComposedRecordingService.java | 2 +- .../io/openvidu/server/rest/SessionRestController.java | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/openvidu-server/src/main/java/io/openvidu/server/recording/ComposedRecordingService.java b/openvidu-server/src/main/java/io/openvidu/server/recording/ComposedRecordingService.java index b99799b5..a83bfa17 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/recording/ComposedRecordingService.java +++ b/openvidu-server/src/main/java/io/openvidu/server/recording/ComposedRecordingService.java @@ -78,7 +78,7 @@ public class ComposedRecordingService { private static final Logger log = LoggerFactory.getLogger(ComposedRecordingService.class); @Autowired - OpenviduConfig openviduConfig; + private OpenviduConfig openviduConfig; @Autowired private SessionEventsHandler sessionHandler; diff --git a/openvidu-server/src/main/java/io/openvidu/server/rest/SessionRestController.java b/openvidu-server/src/main/java/io/openvidu/server/rest/SessionRestController.java index 1d69bdfb..717aa531 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/rest/SessionRestController.java +++ b/openvidu-server/src/main/java/io/openvidu/server/rest/SessionRestController.java @@ -41,6 +41,7 @@ import io.openvidu.java.client.RecordingMode; import io.openvidu.java.client.RecordingProperties; import io.openvidu.java.client.MediaMode; import io.openvidu.java.client.SessionProperties; +import io.openvidu.server.config.OpenviduConfig; import io.openvidu.server.core.ParticipantRole; import io.openvidu.server.core.Session; import io.openvidu.server.core.SessionManager; @@ -61,6 +62,9 @@ public class SessionRestController { @Autowired private ComposedRecordingService recordingService; + + @Autowired + private OpenviduConfig openviduConfig; @RequestMapping(value = "/sessions", method = RequestMethod.GET) public Set getAllSessions() { @@ -165,6 +169,11 @@ public class SessionRestController { // "session" parameter not found return new ResponseEntity(HttpStatus.BAD_REQUEST); } + + if (!this.openviduConfig.isRecordingModuleEnabled()) { + // OpenVidu Server configuration property "openvidu.recording" is set to false + return new ResponseEntity(HttpStatus.NOT_IMPLEMENTED); + } Session session = sessionManager.getSession(sessionId);