ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-server: updateRecordingAttributes to not return object

pull/546/head
pabloFuente 2020-09-24 12:37:20 +02:00
parent 407f72f0d1
commit 593b2fa80d
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedQuickStartRecordingService.java
View File

@ -123,7 +123,7 @@ public class ComposedQuickStartRecordingService extends ComposedRecordingService
e1.printStackTrace(); e1.printStackTrace();
} }
recording = updateRecordingAttributes(recording); updateRecordingAttributes(recording);
this.sealRecordingMetadataFileAsReady(recording, recording.getSize(), recording.getDuration(), this.sealRecordingMetadataFileAsReady(recording, recording.getSize(), recording.getDuration(),
getMetadataFilePath(recording)); getMetadataFilePath(recording));

5
openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java
View File

@ -298,7 +298,7 @@ public class ComposedRecordingService extends RecordingService {
} else { } else {
stopAndRemoveRecordingContainer(recording, containerId, 30); stopAndRemoveRecordingContainer(recording, containerId, 30);
recording = updateRecordingAttributes(recording); updateRecordingAttributes(recording);
this.sealRecordingMetadataFileAsReady(recording, recording.getSize(), recording.getDuration(), this.sealRecordingMetadataFileAsReady(recording, recording.getSize(), recording.getDuration(),
getMetadataFilePath(recording)); getMetadataFilePath(recording));
@ -415,7 +415,7 @@ public class ComposedRecordingService extends RecordingService {
containers.remove(containerId); containers.remove(containerId);
} }
protected Recording updateRecordingAttributes(Recording recording) { protected void updateRecordingAttributes(Recording recording) {
try { try {
RecordingInfoUtils infoUtils = new RecordingInfoUtils(this.openviduConfig.getOpenViduRecordingPath() RecordingInfoUtils infoUtils = new RecordingInfoUtils(this.openviduConfig.getOpenViduRecordingPath()
+ recording.getId() + "/" + recording.getId() + ".info"); + recording.getId() + "/" + recording.getId() + ".info");
@ -432,7 +432,6 @@ public class ComposedRecordingService extends RecordingService {
recording.setHasVideo(infoUtils.hasVideo()); recording.setHasVideo(infoUtils.hasVideo());
} }
infoUtils.deleteFilePath(); infoUtils.deleteFilePath();
return recording;
} catch (IOException e) { } catch (IOException e) {
recording.setStatus(io.openvidu.java.client.Recording.Status.failed); recording.setStatus(io.openvidu.java.client.Recording.Status.failed);
throw new OpenViduException(Code.RECORDING_REPORT_ERROR_CODE, throw new OpenViduException(Code.RECORDING_REPORT_ERROR_CODE,