From 593b2fa80d89d74aae05ee5e7007274310411c09 Mon Sep 17 00:00:00 2001 From: pabloFuente Date: Thu, 24 Sep 2020 12:37:20 +0200 Subject: [PATCH] openvidu-server: updateRecordingAttributes to not return object --- .../service/ComposedQuickStartRecordingService.java | 2 +- .../server/recording/service/ComposedRecordingService.java | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedQuickStartRecordingService.java b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedQuickStartRecordingService.java index c0b8d86c..f1262adb 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedQuickStartRecordingService.java +++ b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedQuickStartRecordingService.java @@ -123,7 +123,7 @@ public class ComposedQuickStartRecordingService extends ComposedRecordingService e1.printStackTrace(); } - recording = updateRecordingAttributes(recording); + updateRecordingAttributes(recording); this.sealRecordingMetadataFileAsReady(recording, recording.getSize(), recording.getDuration(), getMetadataFilePath(recording)); diff --git a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java index 0ddf3581..19020abe 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java +++ b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java @@ -298,7 +298,7 @@ public class ComposedRecordingService extends RecordingService { } else { stopAndRemoveRecordingContainer(recording, containerId, 30); - recording = updateRecordingAttributes(recording); + updateRecordingAttributes(recording); this.sealRecordingMetadataFileAsReady(recording, recording.getSize(), recording.getDuration(), getMetadataFilePath(recording)); @@ -415,7 +415,7 @@ public class ComposedRecordingService extends RecordingService { containers.remove(containerId); } - protected Recording updateRecordingAttributes(Recording recording) { + protected void updateRecordingAttributes(Recording recording) { try { RecordingInfoUtils infoUtils = new RecordingInfoUtils(this.openviduConfig.getOpenViduRecordingPath() + recording.getId() + "/" + recording.getId() + ".info"); @@ -432,7 +432,6 @@ public class ComposedRecordingService extends RecordingService { recording.setHasVideo(infoUtils.hasVideo()); } infoUtils.deleteFilePath(); - return recording; } catch (IOException e) { recording.setStatus(io.openvidu.java.client.Recording.Status.failed); throw new OpenViduException(Code.RECORDING_REPORT_ERROR_CODE,