From cdb77f1be1db30540b5bef9ea6d27b56af20ca67 Mon Sep 17 00:00:00 2001
From: Dario Guarascio <dario.guarascio@gmail.com>
Date: Tue, 12 Oct 2021 22:46:55 +0200
Subject: [PATCH] using constants to define header/footer appearence

---
 lib/constants.js             |  3 +++
 pages/dashboard/[[...id]].js |  3 ++-
 pages/login.js               | 17 +++++++++++------
 pages/settings/index.js      |  3 ++-
 pages/website/[...id].js     |  3 ++-
 5 files changed, 20 insertions(+), 9 deletions(-)

diff --git a/lib/constants.js b/lib/constants.js
index 3eb892bb..51e70fd3 100644
--- a/lib/constants.js
+++ b/lib/constants.js
@@ -8,6 +8,9 @@ export const THEME_CONFIG = `${prefix}.theme`;
 export const VERSION_CHECK = `${prefix}.version-check`;
 export const TOKEN_HEADER = `x-${prefix}-token`;
 
+export const SHOW_HEADER = false;
+export const SHOW_FOOTER = false;
+
 export const DEFAULT_LOCALE = 'en-US';
 export const DEFAULT_THEME = 'light';
 export const DEFAUL_CHART_HEIGHT = 400;
diff --git a/pages/dashboard/[[...id]].js b/pages/dashboard/[[...id]].js
index 66e92873..3e9c458e 100644
--- a/pages/dashboard/[[...id]].js
+++ b/pages/dashboard/[[...id]].js
@@ -3,6 +3,7 @@ import { useRouter } from 'next/router';
 import Layout from 'components/layout/Layout';
 import WebsiteList from 'components/pages/WebsiteList';
 import useRequireLogin from 'hooks/useRequireLogin';
+import { SHOW_HEADER, SHOW_FOOTER } from 'lib/constants';
 
 export default function DashboardPage() {
   const { loading } = useRequireLogin();
@@ -15,7 +16,7 @@ export default function DashboardPage() {
   }
 
   return (
-    <Layout header={false} footer={false}>
+    <Layout header={SHOW_HEADER} footer={SHOW_FOOTER}>
       <WebsiteList userId={userId} />
     </Layout>
   );
diff --git a/pages/login.js b/pages/login.js
index c7e1f28b..e5e9d5ec 100644
--- a/pages/login.js
+++ b/pages/login.js
@@ -7,11 +7,16 @@ import { useRouter } from 'next/router';
 export default function LoginPage() {
   const { query } = useRouter();
   if (query.hash) {
-    return <AutoLogin hash={query.hash} />;
+    return (
+      <Layout title="login" header={false} footer={false} center>
+        <AutoLogin hash={query.hash} />
+      </Layout>
+    );
+  } else {
+    return (
+      <Layout title="login" header={false} footer={false} center>
+        <LoginForm />
+      </Layout>
+    );
   }
-  return (
-    <Layout title="login" header={false} footer={false} center>
-      <LoginForm />
-    </Layout>
-  );
 }
diff --git a/pages/settings/index.js b/pages/settings/index.js
index b4bb2248..26a321ed 100644
--- a/pages/settings/index.js
+++ b/pages/settings/index.js
@@ -2,6 +2,7 @@ import React from 'react';
 import Layout from 'components/layout/Layout';
 import Settings from 'components/pages/Settings';
 import useRequireLogin from 'hooks/useRequireLogin';
+import { SHOW_HEADER, SHOW_FOOTER } from 'lib/constants';
 
 export default function SettingsPage() {
   const { loading } = useRequireLogin();
@@ -11,7 +12,7 @@ export default function SettingsPage() {
   }
 
   return (
-    <Layout>
+    <Layout header={SHOW_HEADER} footer={SHOW_FOOTER}>
       <Settings />
     </Layout>
   );
diff --git a/pages/website/[...id].js b/pages/website/[...id].js
index 6a5fda7d..bc32a013 100644
--- a/pages/website/[...id].js
+++ b/pages/website/[...id].js
@@ -3,6 +3,7 @@ import { useRouter } from 'next/router';
 import Layout from 'components/layout/Layout';
 import WebsiteDetails from 'components/pages/WebsiteDetails';
 import useRequireLogin from 'hooks/useRequireLogin';
+import { SHOW_HEADER, SHOW_FOOTER } from 'lib/constants';
 
 export default function DetailsPage() {
   const { loading } = useRequireLogin();
@@ -16,7 +17,7 @@ export default function DetailsPage() {
   const [websiteId] = id;
 
   return (
-    <Layout header={false} footer={false}>
+    <Layout header={SHOW_HEADER} footer={SHOW_FOOTER}>
       <WebsiteDetails websiteId={websiteId} />
     </Layout>
   );