From fbc33ce746b45bb930401b5c1700ed41b51088f0 Mon Sep 17 00:00:00 2001 From: Nicholas Fasching Date: Fri, 8 Jul 2022 19:36:19 -0400 Subject: [PATCH 1/3] Add Filter to Have Direct Referrer --- lib/filters.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/filters.js b/lib/filters.js index f3237a0a..f4542083 100644 --- a/lib/filters.js +++ b/lib/filters.js @@ -50,13 +50,15 @@ export const refFilter = (data, { domain, domainOnly, raw }) => { const links = {}; const isValidRef = referrer => { - return ( - referrer !== '' && referrer !== null && !referrer.startsWith('/') && !referrer.startsWith('#') - ); + return referrer !== null && !referrer.startsWith('/') && !referrer.startsWith('#'); }; const cleanUrl = url => { try { + if (url === '') { + return 'direct'; + } + const { hostname, origin, pathname, searchParams, protocol } = new URL(url); if (regex.test(url)) { From b90b2b9bb2c7e3674ec9b55baaed076e64967fae Mon Sep 17 00:00:00 2001 From: Nicholas Fasching <91689117+njfdev@users.noreply.github.com> Date: Sat, 9 Jul 2022 07:46:45 -0400 Subject: [PATCH 2/3] Update lib/filters.js Co-authored-by: Rohan Deb Sarkar --- lib/filters.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/filters.js b/lib/filters.js index f4542083..9503ed67 100644 --- a/lib/filters.js +++ b/lib/filters.js @@ -56,7 +56,7 @@ export const refFilter = (data, { domain, domainOnly, raw }) => { const cleanUrl = url => { try { if (url === '') { - return 'direct'; + return 'direct/none'; } const { hostname, origin, pathname, searchParams, protocol } = new URL(url); From 448a62d884fb6f60c065e30e71b3ad02adbad12b Mon Sep 17 00:00:00 2001 From: Nicholas Fasching <91689117+njfdev@users.noreply.github.com> Date: Sat, 9 Jul 2022 08:53:06 -0400 Subject: [PATCH 3/3] Update Blank Referrer Text I think this capitalization and spacing looks better after looking at it again. --- lib/filters.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/filters.js b/lib/filters.js index 9503ed67..baefcda7 100644 --- a/lib/filters.js +++ b/lib/filters.js @@ -56,7 +56,7 @@ export const refFilter = (data, { domain, domainOnly, raw }) => { const cleanUrl = url => { try { if (url === '') { - return 'direct/none'; + return 'Direct / None'; } const { hostname, origin, pathname, searchParams, protocol } = new URL(url);