ambiser
/
umami
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove async script attribute 

using async and defer on script tags is considered an [antipattern](https://almanac.httparchive.org/en/2022/javascript#async-defer-module-and-nomodule) as defer will be ignored. Defer is the preferred behaviour in most situations.
pull/1731/head
Sam Vargas 2023-01-05 12:54:07 +00:00
parent 796c65fa29
commit 258e8bb3d6
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
components/forms/TrackingCodeForm.js
View File

@ -5,7 +5,7 @@ import { Form, FormRow, TextArea } from 'react-basics';
export default function TrackingCodeForm({ websiteId }) { export default function TrackingCodeForm({ websiteId }) {
const ref = useRef(null); const ref = useRef(null);
const { trackerScriptName } = useConfig(); const { trackerScriptName } = useConfig();
const code = `<script async defer src="${trackerScriptName}" data-website-id="${websiteId}"></script>`; const code = `<script defer src="${trackerScriptName}" data-website-id="${websiteId}"></script>`;
return ( return (
<> <>

1
components/pages/TestConsole.js
View File

@ -50,7 +50,6 @@ export default function TestConsole() {
<Head> <Head>
{typeof window !== 'undefined' && website && ( {typeof window !== 'undefined' && website && (
<script <script
async
defer defer
data-website-id={website.id} data-website-id={website.id}
src={`${basePath}/umami.js`} src={`${basePath}/umami.js`}