From cc9b1d21cbfcc63e9213697053ccd64e3960e436 Mon Sep 17 00:00:00 2001 From: Francis Cao Date: Thu, 13 Apr 2023 16:14:05 -0700 Subject: [PATCH 1/3] fix delete team confirmation message --- components/pages/settings/teams/TeamDeleteForm.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/pages/settings/teams/TeamDeleteForm.js b/components/pages/settings/teams/TeamDeleteForm.js index fe300aec..66752d0b 100644 --- a/components/pages/settings/teams/TeamDeleteForm.js +++ b/components/pages/settings/teams/TeamDeleteForm.js @@ -19,7 +19,7 @@ export default function TeamDeleteForm({ teamId, teamName, onSave, onClose }) { return (

- {teamName} }} /> + {teamName} }} />

From 887b3abb291e69ee83ebfb284d28ede6ac5e8998 Mon Sep 17 00:00:00 2001 From: Francis Cao Date: Thu, 13 Apr 2023 17:10:04 -0700 Subject: [PATCH 2/3] Fix deleteWebsite message --- .../pages/settings/websites/WebsiteDeleteForm.js | 6 ++++-- lang/en-US.json | 2 +- public/intl/messages/en-US.json | 10 +++++++++- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/components/pages/settings/websites/WebsiteDeleteForm.js b/components/pages/settings/websites/WebsiteDeleteForm.js index 0661c515..6bac4397 100644 --- a/components/pages/settings/websites/WebsiteDeleteForm.js +++ b/components/pages/settings/websites/WebsiteDeleteForm.js @@ -13,7 +13,7 @@ import useMessages from 'hooks/useMessages'; const CONFIRM_VALUE = 'DELETE'; export default function WebsiteDeleteForm({ websiteId, onSave, onClose }) { - const { formatMessage, labels, messages } = useMessages(); + const { formatMessage, labels, messages, FormattedMessage } = useMessages(); const { del, useMutation } = useApi(); const { mutate, error } = useMutation(data => del(`/websites/${websiteId}`, data)); @@ -28,7 +28,9 @@ export default function WebsiteDeleteForm({ websiteId, onSave, onClose }) { return ( -

{formatMessage(messages.deleteWebsite, { confirmation: CONFIRM_VALUE })}

+

+ +

value === CONFIRM_VALUE }}> diff --git a/lang/en-US.json b/lang/en-US.json index 19ec8537..233253d7 100644 --- a/lang/en-US.json +++ b/lang/en-US.json @@ -113,7 +113,7 @@ "message.confirm-delete": "Are you sure you want to delete {target}?", "message.confirm-leave": "Are you sure you want to leave {target}?", "message.confirm-reset": "Are you sure you want to reset {target}'s statistics?", - "message.delete-website": "Delete website", + "message.delete-website": "To delete this website, type {confirmation} in the box below to confirm.", "message.delete-website-warning": "All associated data will be deleted as well.", "message.error": "Something went wrong.", "message.event-log": "{event} on {url}", diff --git a/public/intl/messages/en-US.json b/public/intl/messages/en-US.json index d8ce582a..5dc57b9e 100644 --- a/public/intl/messages/en-US.json +++ b/public/intl/messages/en-US.json @@ -758,7 +758,15 @@ "message.delete-website": [ { "type": 0, - "value": "Delete website" + "value": "To delete this website, type " + }, + { + "type": 1, + "value": "confirmation" + }, + { + "type": 0, + "value": " in the box below to confirm." } ], "message.delete-website-warning": [ From aa418e0beda893e1a575ec2e09f7e27f492ebd26 Mon Sep 17 00:00:00 2001 From: Francis Cao Date: Thu, 13 Apr 2023 17:20:42 -0700 Subject: [PATCH 3/3] add delete user label for modal --- components/messages.js | 1 + components/pages/settings/users/UsersTable.js | 2 +- components/pages/settings/websites/WebsiteDeleteForm.js | 5 ++++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/components/messages.js b/components/messages.js index bfb173e8..de92ce8f 100644 --- a/components/messages.js +++ b/components/messages.js @@ -10,6 +10,7 @@ export const labels = defineMessages({ leave: { id: 'label.leave', defaultMessage: 'Leave' }, users: { id: 'label.users', defaultMessage: 'Users' }, createUser: { id: 'label.create-user', defaultMessage: 'Create user' }, + deleteUser: { id: 'label.delete-users', defaultMessage: 'Delete user' }, username: { id: 'label.username', defaultMessage: 'Username' }, password: { id: 'label.password', defaultMessage: 'Password' }, role: { id: 'label.role', defaultMessage: 'Role' }, diff --git a/components/pages/settings/users/UsersTable.js b/components/pages/settings/users/UsersTable.js index 5ea3806c..c60f11ff 100644 --- a/components/pages/settings/users/UsersTable.js +++ b/components/pages/settings/users/UsersTable.js @@ -52,7 +52,7 @@ export default function UsersTable({ data = [], onDelete }) { {formatMessage(labels.delete)} - + {close => (

- + {CONFIRM_VALUE} }} + />

value === CONFIRM_VALUE }}>