From f2c37f29a5d901aa0488f93220c13d2901b9d11b Mon Sep 17 00:00:00 2001 From: pabloFuente Date: Thu, 8 Oct 2020 18:38:53 +0200 Subject: [PATCH] openvidu-server: TODO comment in Participant class --- .../main/java/io/openvidu/server/core/Participant.java | 8 ++++++-- .../src/main/java/io/openvidu/server/rpc/RpcHandler.java | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/openvidu-server/src/main/java/io/openvidu/server/core/Participant.java b/openvidu-server/src/main/java/io/openvidu/server/core/Participant.java index 1c4fd73f..5184c684 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/core/Participant.java +++ b/openvidu-server/src/main/java/io/openvidu/server/core/Participant.java @@ -38,6 +38,10 @@ public class Participant { protected GeoLocation location; // Location of the participant protected String platform; // Platform used by the participant to connect to the session protected EndpointType endpointType; // Type of participant (web participant, IP cam participant...) + + // TODO + // Unify with "PublisherEndpoint.MediaOptions" + // Also unify "streamPropertyChanged" and "videoData" RPCs when possible protected Integer videoWidth = 0; protected Integer videoHeight = 0; protected Boolean videoActive = false; @@ -145,7 +149,7 @@ public class Participant { public EndpointType getEndpointType() { return this.endpointType; } - + public Integer getVideoWidth() { return videoWidth; } @@ -161,7 +165,7 @@ public class Participant { public void setVideoHeight(Integer videoHeight) { this.videoHeight = videoHeight; } - + public Boolean isVideoActive() { return videoActive; } diff --git a/openvidu-server/src/main/java/io/openvidu/server/rpc/RpcHandler.java b/openvidu-server/src/main/java/io/openvidu/server/rpc/RpcHandler.java index 05f6fdf8..3d627340 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/rpc/RpcHandler.java +++ b/openvidu-server/src/main/java/io/openvidu/server/rpc/RpcHandler.java @@ -636,7 +636,7 @@ public class RpcHandler extends DefaultJsonRpcHandler { new JsonObject(), e); } } - + private void updateVideoData(RpcConnection rpcConnection, Request request) { Participant participant; try { @@ -648,7 +648,7 @@ public class RpcHandler extends DefaultJsonRpcHandler { sessionManager.onVideoData(participant, request.getId(), height, width, videoActive, audioActive); } catch (OpenViduException e) { log.error("Error getting video data: {}", e.toString()); - } + } } public void leaveRoomAfterConnClosed(String participantPrivateId, EndReason reason) {