ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
9
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-test-e2e: fix test remoteVideoElementSurvivesParticipantChangesTest to work on a single Chrome user

pull/907/head
pabloFuente 2026-09-05 15:49:48 +02:00
parent 2aa0f99ec6
commit e77bb39654
1 changed files with 42 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
openvidu-test-e2e/src/test/java/io/openvidu/test/e2e/OpenViduTestAppE2eTest.java
View File

@ -4746,59 +4746,65 @@ public class OpenViduTestAppE2eTest extends AbstractOpenViduTestappE2eTest {
void remoteVideoElementSurvivesParticipantChangesTest() throws Exception { void remoteVideoElementSurvivesParticipantChangesTest() throws Exception {
// openvidu-testapp test: it must keep the DOM elements of the remote tracks // openvidu-testapp test: it must keep the DOM elements of the remote tracks
// already rendered when the remote participant list changes // already rendered when the remote participant list changes
OpenViduTestappUser publisher = setupBrowserAndConnectToOpenViduTestapp("chrome"); OpenViduTestappUser user = setupBrowserAndConnectToOpenViduTestapp("chrome");
OpenViduTestappUser subscriber = setupBrowserAndConnectToOpenViduTestapp("chrome");
OpenViduTestappUser newcomer = setupBrowserAndConnectToOpenViduTestapp("chrome");
log.info("Remote video element survives participant changes"); log.info("Remote video element survives participant changes");
this.addOnlyPublisherVideo(publisher, false, false, false); this.addOnlyPublisherVideo(user, false, false, false);
this.joinRoomAs(publisher, "publisher"); this.joinRoomAs(user, 0, "publisher");
publisher.getEventManager().waitUntilEventReaches("localTrackPublished", "RoomEvent", 1); user.getEventManager().waitUntilEventReaches(0, "localTrackPublished", "RoomEvent", 1);
this.addSubscriber(subscriber, false); this.addSubscriber(user, false);
this.joinRoomAs(subscriber, "subscriber"); this.joinRoomAs(user, 1, "subscriber");
subscriber.getEventManager().waitUntilEventReaches("trackSubscribed", "RoomEvent", 1); user.getEventManager().waitUntilEventReaches(1, "trackSubscribed", "RoomEvent", 1);
subscriber.getWaiter().until(ExpectedConditions.numberOfElementsToBe(By.tagName("video"), 1)); final By subscriberVideos = By.cssSelector("#openvidu-instance-1 video");
WebElement remoteVideo = subscriber.getDriver() user.getWaiter().until(ExpectedConditions.numberOfElementsToBe(subscriberVideos, 1));
.findElement(By.cssSelector("#openvidu-instance-0 video.remote")); WebElement remoteVideo = user.getDriver().findElement(By.cssSelector("#openvidu-instance-1 video.remote"));
this.waitUntilSubscriberFramesPerSecondNotZero(subscriber, remoteVideo); this.waitUntilSubscriberFramesPerSecondNotZero(user, remoteVideo);
// A participant joins: the subscriber's remote participant list grows // A participant joins: the subscriber's remote participant list grows
this.addSubscriber(newcomer, false); this.addSubscriber(user, false);
this.joinRoomAs(newcomer, "newcomer"); this.joinRoomAs(user, 2, "newcomer");
subscriber.getEventManager().waitUntilEventReaches("participantConnected", "RoomEvent", 1); user.getEventManager().waitUntilEventReaches(1, "participantConnected", "RoomEvent", 1);
this.assertRemoteVideoElementKept(subscriber, remoteVideo, 1, "a participant joined"); this.assertRemoteVideoElementKept(user, remoteVideo, subscriberVideos, 1, "a participant joined");
// The publisher publishes a second video track: its publication list grows // The publisher publishes a second video track: its publication list grows
publisher.getDriver().findElement(By.cssSelector("#openvidu-instance-0 .add-video-btn")).click(); user.getDriver().findElement(By.cssSelector("#openvidu-instance-0 .add-video-btn")).click();
publisher.getEventManager().waitUntilEventReaches("localTrackPublished", "RoomEvent", 2); user.getEventManager().waitUntilEventReaches(0, "localTrackPublished", "RoomEvent", 2);
subscriber.getEventManager().waitUntilEventReaches("trackSubscribed", "RoomEvent", 2); user.getEventManager().waitUntilEventReaches(1, "trackSubscribed", "RoomEvent", 2);
subscriber.getWaiter().until(ExpectedConditions.numberOfElementsToBe(By.tagName("video"), 2)); user.getWaiter().until(ExpectedConditions.numberOfElementsToBe(subscriberVideos, 2));
this.assertRemoteVideoElementKept(subscriber, remoteVideo, 2, "the publisher published a second track"); this.assertRemoteVideoElementKept(user, remoteVideo, subscriberVideos, 2,
"the publisher published a second track");
// A participant leaves: the subscriber's remote participant list shrinks // The participant leaves: the subscriber's remote participant list shrinks
gracefullyLeaveParticipants(newcomer, 1); this.leaveRoom(user, 2);
subscriber.getEventManager().waitUntilEventReaches("participantDisconnected", "RoomEvent", 1); user.getEventManager().waitUntilEventReaches(1, "participantDisconnected", "RoomEvent", 1);
this.assertRemoteVideoElementKept(subscriber, remoteVideo, 2, "a participant left"); this.assertRemoteVideoElementKept(user, remoteVideo, subscriberVideos, 2, "a participant left");
// And the kept element is still a playing video // And the kept element is still a playing video
this.waitUntilSubscriberFramesPerSecondNotZero(subscriber, remoteVideo); this.waitUntilSubscriberFramesPerSecondNotZero(user, remoteVideo);
gracefullyLeaveParticipants(subscriber, 1); this.leaveRoom(user, 1);
gracefullyLeaveParticipants(publisher, 1); this.leaveRoom(user, 0);
} }
private void joinRoomAs(OpenViduTestappUser user, String identity) throws Exception { private void joinRoomAs(OpenViduTestappUser user, int instance, String identity) throws Exception {
WebElement participantNameInput = user.getDriver().findElement(By.id("participant-name-input-0")); WebElement participantNameInput = user.getDriver().findElement(By.id("participant-name-input-" + instance));
participantNameInput.clear(); participantNameInput.clear();
participantNameInput.sendKeys(identity); participantNameInput.sendKeys(identity);
user.getDriver().findElements(By.className("connect-btn")).forEach(el -> el.sendKeys(Keys.ENTER)); user.getDriver().findElement(By.cssSelector("#openvidu-instance-" + instance + " .connect-btn"))
user.getEventManager().waitUntilEventReaches("connected", "RoomEvent", 1); .sendKeys(Keys.ENTER);
user.getEventManager().waitUntilEventReaches(instance, "connected", "RoomEvent", 1);
} }
private void assertRemoteVideoElementKept(OpenViduTestappUser user, WebElement remoteVideo, int expectedVideos, private void leaveRoom(OpenViduTestappUser user, int instance) throws Exception {
String change) { user.getDriver().findElement(By.cssSelector("#openvidu-instance-" + instance + " .disconnect-btn"))
.sendKeys(Keys.ENTER);
user.getEventManager().waitUntilEventReaches(instance, "disconnected", "RoomEvent", 1);
}
private void assertRemoteVideoElementKept(OpenViduTestappUser user, WebElement remoteVideo, By videos,
int expectedVideos, String change) {
try { try {
Assertions.assertTrue(remoteVideo.isDisplayed(), Assertions.assertTrue(remoteVideo.isDisplayed(),
"The remote video element is no longer displayed after " + change); "The remote video element is no longer displayed after " + change);
@ -4806,7 +4812,7 @@ public class OpenViduTestAppE2eTest extends AbstractOpenViduTestappE2eTest {
Assertions.fail("The remote video element was re-created after " + change Assertions.fail("The remote video element was re-created after " + change
+ ": the WebElement located before is stale", e); + ": the WebElement located before is stale", e);
} }
Assertions.assertEquals(expectedVideos, user.getDriver().findElements(By.tagName("video")).size(), Assertions.assertEquals(expectedVideos, user.getDriver().findElements(videos).size(),
"Wrong number of videos after " + change); "Wrong number of videos after " + change);
} }