ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-components: Clean code

pull/748/head
Carlos Santos 2022-10-19 12:29:02 +02:00
parent fd6a076f55
commit df128e0591
2 changed files with 22 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openvidu-components-angular/e2e/utils.po.test.ts
View File

@ -58,9 +58,6 @@ export class OpenViduComponentsPO {
expect(await this.isPresent('#media-buttons-container')).to.be.true; expect(await this.isPresent('#media-buttons-container')).to.be.true;
} }
// Angular library
async clickOn(selector: string): Promise<void> { async clickOn(selector: string): Promise<void> {
const element = await this.waitForElement(selector); const element = await this.waitForElement(selector);
await element.click(); await element.click();

44
openvidu-components-angular/projects/openvidu-angular/src/lib/services/openvidu/openvidu.service.ts
View File

@ -1,18 +1,18 @@
import { Injectable } from '@angular/core'; import { Injectable } from '@angular/core';
import { Connection, OpenVidu, OpenViduError, OpenViduErrorName, Publisher, PublisherProperties, Session, SignalOptions, Stream } from 'openvidu-browser'; import { Connection, OpenVidu, OpenViduError, OpenViduErrorName, Publisher, PublisherProperties, Session, SignalOptions } from 'openvidu-browser';
import { LoggerService } from '../logger/logger.service'; import { LoggerService } from '../logger/logger.service';
import { ILogger } from '../../models/logger.model';
import { Signal } from '../../models/signal.model';
import { OpenViduAngularConfigService } from '../config/openvidu-angular.config.service';
import { PlatformService } from '../platform/platform.service';
import { DeviceService } from '../device/device.service';
import { CameraType } from '../../models/device.model'; import { CameraType } from '../../models/device.model';
import { ScreenType, VideoType } from '../../models/video-type.model'; import { ILogger } from '../../models/logger.model';
import { ParticipantService } from '../participant/participant.service';
import { TokenService } from '../token/token.service';
import { OpenViduEdition } from '../../models/openvidu.model'; import { OpenViduEdition } from '../../models/openvidu.model';
import { Signal } from '../../models/signal.model';
import { ScreenType, VideoType } from '../../models/video-type.model';
import { OpenViduAngularConfigService } from '../config/openvidu-angular.config.service';
import { DeviceService } from '../device/device.service';
import { ParticipantService } from '../participant/participant.service';
import { PlatformService } from '../platform/platform.service';
import { TokenService } from '../token/token.service';
@Injectable({ @Injectable({
providedIn: 'root' providedIn: 'root'
@ -444,19 +444,19 @@ export class OpenViduService {
} }
} }
private destroyPublisher(publisher: Publisher): void { // private destroyPublisher(publisher: Publisher): void {
if (!!publisher) { // if (!!publisher) {
if (publisher.stream.getWebRtcPeer()) { // if (publisher.stream.getWebRtcPeer()) {
publisher.stream.disposeWebRtcPeer(); // publisher.stream.disposeWebRtcPeer();
} // }
publisher.stream.disposeMediaStream(); // publisher.stream.disposeMediaStream();
if (publisher.id === this.participantService.getMyCameraPublisher().id) { // if (publisher.id === this.participantService.getMyCameraPublisher().id) {
this.participantService.setMyCameraPublisher(publisher); // this.participantService.setMyCameraPublisher(publisher);
} else if (publisher.id === this.participantService.getMyScreenPublisher().id) { // } else if (publisher.id === this.participantService.getMyScreenPublisher().id) {
this.participantService.setMyScreenPublisher(publisher); // this.participantService.setMyScreenPublisher(publisher);
} // }
} // }
} // }
private async createMediaStream(pp: PublisherProperties): Promise<MediaStream> { private async createMediaStream(pp: PublisherProperties): Promise<MediaStream> {
let mediaStream: MediaStream; let mediaStream: MediaStream;