From de9f195fd5e863758473aa958d9775a1bdd53572 Mon Sep 17 00:00:00 2001 From: cruizba Date: Mon, 10 Apr 2023 11:25:29 +0200 Subject: [PATCH] openvidu-recording: Remove CHROME_VERSION argument --- openvidu-server/docker/openvidu-recording/Dockerfile | 2 -- .../docker/openvidu-recording/create_image.sh | 12 +++++------- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/openvidu-server/docker/openvidu-recording/Dockerfile b/openvidu-server/docker/openvidu-recording/Dockerfile index 8a132ec5..36b3ab3e 100644 --- a/openvidu-server/docker/openvidu-recording/Dockerfile +++ b/openvidu-server/docker/openvidu-recording/Dockerfile @@ -1,8 +1,6 @@ FROM ubuntu:22.04 LABEL maintainer="OpenVidu info@openvidu.io" -ARG CHROME_VERSION - # Install packages RUN apt update && apt -y upgrade && apt install -y \ wget \ diff --git a/openvidu-server/docker/openvidu-recording/create_image.sh b/openvidu-server/docker/openvidu-recording/create_image.sh index f9300955..1d793549 100755 --- a/openvidu-server/docker/openvidu-recording/create_image.sh +++ b/openvidu-server/docker/openvidu-recording/create_image.sh @@ -1,12 +1,10 @@ #!/bin/bash -x -CHROME_VERSION=$1 # https://www.ubuntuupdates.org/package_logs?noppa=&page=1&type=ppas&vals=8# -TAG=$2 +TAG=$1 -if [[ ! -z $CHROME_VERSION && ! -z $TAG ]]; then - docker build --rm --pull --no-cache --build-arg CHROME_VERSION="$CHROME_VERSION" -t openvidu/openvidu-recording:$TAG . +if [[ -n $TAG ]]; then + docker build --rm --pull --no-cache -t "openvidu/openvidu-recording:$TAG" . else - echo "Error: You need to specify a Chrome version as first argument and a docker tag as second argument" - echo "./create_image.sh 110.0.5481.177-1 2.26.0" - echo "You can obtain a valid Chrome version from https://www.ubuntuupdates.org/package_logs?noppa=&page=1&type=ppas&vals=8#" + echo "Error: You need to specify a docker tag as second argument" + echo "./create_image.sh 2.26.0" fi