From d32aefb9008fbea5354554ef57e0e765e62eb783 Mon Sep 17 00:00:00 2001 From: cruizba Date: Fri, 25 Feb 2022 16:24:27 +0100 Subject: [PATCH] openvidu-server,openvidu-node-client: Typos and missing parameter in openvidu-node-client for IceServerProperties --- .../io/openvidu/java/client/IceServerProperties.java | 11 +++++++---- openvidu-node-client/src/IceServerProperties.ts | 8 ++++++++ .../io/openvidu/server/config/OpenviduConfig.java | 2 +- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/openvidu-java-client/src/main/java/io/openvidu/java/client/IceServerProperties.java b/openvidu-java-client/src/main/java/io/openvidu/java/client/IceServerProperties.java index abe3c6ff..e59a9c23 100644 --- a/openvidu-java-client/src/main/java/io/openvidu/java/client/IceServerProperties.java +++ b/openvidu-java-client/src/main/java/io/openvidu/java/client/IceServerProperties.java @@ -129,9 +129,12 @@ public class IceServerProperties { /** * Secret for TURN authentication based on: - * - https://tools.ietf.org/html/draft-uberti-behave-turn-rest-00 - * - https://www.ietf.org/proceedings/87/slides/slides-87-behave-10.pdf - * This will generate credentials valid for 24 hours which is the recommended value + * + * This will generate credentials valid for 24 hours which is the recommended value. You need to setup in your TURN service this same secret value + * which uses HMAC SHA1 as encryption algorithm. A TURN implementation which by default uses this is COTURN with static-auth-secret parameter. */ public IceServerProperties.Builder staticAuthSecret(String staticAuthSecret) { this.staticAuthSecret = staticAuthSecret; @@ -318,7 +321,7 @@ public class IceServerProperties { private void generateTURNCredentials() throws NoSuchAlgorithmException, InvalidKeyException { // 1. Generate random username - char[] ALPHANUMERIC =("abcdefghijklmnopqrstuvwxyzABCDEFGHIJK " + + char[] ALPHANUMERIC =("abcdefghijklmnopqrstuvwxyzABCDEFGHIJK" + "LMNOPQRSTUVWXYZ0123456789").toCharArray(); int MAX_LENGTH = 8; StringBuilder randomUsername = new StringBuilder(); diff --git a/openvidu-node-client/src/IceServerProperties.ts b/openvidu-node-client/src/IceServerProperties.ts index 3484ea04..4c80410c 100644 --- a/openvidu-node-client/src/IceServerProperties.ts +++ b/openvidu-node-client/src/IceServerProperties.ts @@ -27,6 +27,14 @@ export interface IceServerProperties { */ url: string; + /** + * Secret for TURN authentication based on: + * - [https://tools.ietf.org/html/draft-uberti-behave-turn-rest-00](https://tools.ietf.org/html/draft-uberti-behave-turn-rest-00) + * - [https://www.ietf.org/proceedings/87/slides/slides-87-behave-10.pdf](https://www.ietf.org/proceedings/87/slides/slides-87-behave-10.pdf) + * This will generate credentials valid for 24 hours which is the recommended value + */ + staticAuthSecret?: string; + /** * Set a username for the ICE Server you want to use. * This parameter should be defined only for TURN, not for STUN ICE Servers. diff --git a/openvidu-server/src/main/java/io/openvidu/server/config/OpenviduConfig.java b/openvidu-server/src/main/java/io/openvidu/server/config/OpenviduConfig.java index bc8e66c7..752eeb45 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/config/OpenviduConfig.java +++ b/openvidu-server/src/main/java/io/openvidu/server/config/OpenviduConfig.java @@ -1222,5 +1222,5 @@ public class OpenviduConfig { builderCheck.build(); return builder; } - + }