discover_my_public_ip.sh ShellCheck fixes

pull/447/head
pabloFuente 2020-04-21 13:42:06 +02:00
parent f2f12ac0d1
commit c2198b5d01
3 changed files with 15 additions and 15 deletions

View File

@ -9,7 +9,7 @@ function valid_ip()
if [[ $ip =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then if [[ $ip =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then
OIFS=$IFS OIFS=$IFS
IFS='.' IFS='.'
ip=($ip) ip=("$ip")
IFS=$OIFS IFS=$OIFS
[[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \ [[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \
&& ${ip[2]} -le 255 && ${ip[3]} -le 255 ]] && ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]
@ -32,12 +32,12 @@ SERVICES=(
# Get public ip # Get public ip
for service in "${SERVICES[@]}"; do for service in "${SERVICES[@]}"; do
RUN_COMMAND=$($service | tr -d '[:space:]') RUN_COMMAND=$($service | tr -d '[:space:]')
IP=$(echo $RUN_COMMAND | cut -d':' -f1) IP=$(echo "$RUN_COMMAND" | cut -d':' -f1)
HTTP_CODE=$(echo $RUN_COMMAND | cut -d':' -f2) HTTP_CODE=$(echo "$RUN_COMMAND" | cut -d':' -f2)
if [ "$HTTP_CODE" == "200" ]; then if [ "$HTTP_CODE" == "200" ]; then
if valid_ip "$IP"; then if valid_ip "$IP"; then
printf "$IP" printf "%s" "$IP"
exit 0 exit 0
fi fi
fi fi

View File

@ -9,7 +9,7 @@ function valid_ip()
if [[ $ip =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then if [[ $ip =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then
OIFS=$IFS OIFS=$IFS
IFS='.' IFS='.'
ip=($ip) ip=("$ip")
IFS=$OIFS IFS=$OIFS
[[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \ [[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \
&& ${ip[2]} -le 255 && ${ip[3]} -le 255 ]] && ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]
@ -32,12 +32,12 @@ SERVICES=(
# Get public ip # Get public ip
for service in "${SERVICES[@]}"; do for service in "${SERVICES[@]}"; do
RUN_COMMAND=$($service | tr -d '[:space:]') RUN_COMMAND=$($service | tr -d '[:space:]')
IP=$(echo $RUN_COMMAND | cut -d':' -f1) IP=$(echo "$RUN_COMMAND" | cut -d':' -f1)
HTTP_CODE=$(echo $RUN_COMMAND | cut -d':' -f2) HTTP_CODE=$(echo "$RUN_COMMAND" | cut -d':' -f2)
if [ "$HTTP_CODE" == "200" ]; then if [ "$HTTP_CODE" == "200" ]; then
if valid_ip "$IP"; then if valid_ip "$IP"; then
printf "$IP" printf "%s" "$IP"
exit 0 exit 0
fi fi
fi fi

View File

@ -9,7 +9,7 @@ function valid_ip()
if [[ $ip =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then if [[ $ip =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then
OIFS=$IFS OIFS=$IFS
IFS='.' IFS='.'
ip=($ip) ip=("$ip")
IFS=$OIFS IFS=$OIFS
[[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \ [[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \
&& ${ip[2]} -le 255 && ${ip[3]} -le 255 ]] && ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]
@ -32,12 +32,12 @@ SERVICES=(
# Get public ip # Get public ip
for service in "${SERVICES[@]}"; do for service in "${SERVICES[@]}"; do
RUN_COMMAND=$($service | tr -d '[:space:]') RUN_COMMAND=$($service | tr -d '[:space:]')
IP=$(echo $RUN_COMMAND | cut -d':' -f1) IP=$(echo "$RUN_COMMAND" | cut -d':' -f1)
HTTP_CODE=$(echo $RUN_COMMAND | cut -d':' -f2) HTTP_CODE=$(echo "$RUN_COMMAND" | cut -d':' -f2)
if [ "$HTTP_CODE" == "200" ]; then if [ "$HTTP_CODE" == "200" ]; then
if valid_ip "$IP"; then if valid_ip "$IP"; then
printf "$IP" printf "%s" "$IP"
exit 0 exit 0
fi fi
fi fi