ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
9
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-test-e2e: uncomment old TODOS before mediasoup update 

recordingStatusChanged event is now received with mediasoup when a room-composite egress is stopped
pull/894/head
pabloFuente 2026-04-21 22:18:24 +02:00
parent 66001d8f11
commit b5dc6d8517
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
openvidu-test-e2e/src/test/java/io/openvidu/test/e2e/OpenViduTestAppE2eTest.java
View File

@ -371,11 +371,11 @@ public class OpenViduTestAppE2eTest extends AbstractOpenViduTestappE2eTest {
user.getEventManager().waitUntilEventReaches("connectionQualityChanged", "ParticipantEvent", 4); user.getEventManager().waitUntilEventReaches("connectionQualityChanged", "ParticipantEvent", 4);
// Expect the connection quality events to include as text content: "excellent" // Expect the connection quality events to include as text content: "excellent"
user.getDriver().findElements(By.cssSelector(".connectionQualityChanged-TestParticipant0 .event-content")). user.getDriver().findElements(By.cssSelector(".connectionQualityChanged-TestParticipant0 .event-content"))
forEach(el -> Assertions.assertTrue(el.getText().contains("excellent"), .forEach(el -> Assertions.assertTrue(el.getText().contains("excellent"),
"Expected connection quality to be excellent")); "Expected connection quality to be excellent"));
user.getDriver().findElements(By.cssSelector(".connectionQualityChanged-TestParticipant1 .event-content")). user.getDriver().findElements(By.cssSelector(".connectionQualityChanged-TestParticipant1 .event-content"))
forEach(el -> Assertions.assertTrue(el.getText().contains("excellent"), .forEach(el -> Assertions.assertTrue(el.getText().contains("excellent"),
"Expected connection quality to be excellent")); "Expected connection quality to be excellent"));
gracefullyLeaveParticipants(user, 2); gracefullyLeaveParticipants(user, 2);
@ -1750,11 +1750,8 @@ public class OpenViduTestAppE2eTest extends AbstractOpenViduTestappE2eTest {
user.getDriver().findElement(By.cssSelector("#start-" + egressType + "-egress-api-btn")).click(); user.getDriver().findElement(By.cssSelector("#start-" + egressType + "-egress-api-btn")).click();
// TODO: UNCOMMENT WHEN MEDIASOUP IS ABLE TO MANAGE ABRUPT user.getEventManager().waitUntilEventReaches("recordingStatusChanged",
// CONNECTIONSTATECHANGED DISOCONNECTED/FAILED "RoomEvent", 1);
// https://mediasoup.discourse.group/t/mediasoup-3-13-20-released-with-server-side-ice-consent-check-and-a-critical-fix/5864
// user.getEventManager().waitUntilEventReaches("recordingStatusChanged",
// "RoomEvent", 1);
WebElement egressIdField = user.getDriver().findElement(By.id("egress-id-field")); WebElement egressIdField = user.getDriver().findElement(By.id("egress-id-field"));
WebDriverWait wait = new WebDriverWait(user.getDriver(), Duration.ofSeconds(10)); WebDriverWait wait = new WebDriverWait(user.getDriver(), Duration.ofSeconds(10));
@ -1775,11 +1772,8 @@ public class OpenViduTestAppE2eTest extends AbstractOpenViduTestappE2eTest {
this.checkRecordingInEgressBackupFolder(egress); this.checkRecordingInEgressBackupFolder(egress);
} }
// TODO: UNCOMMENT WHEN MEDIASOUP IS ABLE TO MANAGE ABRUPT user.getEventManager().waitUntilEventReaches("recordingStatusChanged",
// CONNECTIONSTATECHANGED DISOCONNECTED/FAILED "RoomEvent", 2);
// https://mediasoup.discourse.group/t/mediasoup-3-13-20-released-with-server-side-ice-consent-check-and-a-critical-fix/5864
// user.getEventManager().waitUntilEventReaches("recordingStatusChanged",
// "RoomEvent", 2);
} }
private JsonObject waitUntilEgressStatus(OpenViduTestappUser user, String egressId, String egressStatus, private JsonObject waitUntilEgressStatus(OpenViduTestappUser user, String egressId, String egressStatus,