ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-browser: Fixed bug using speaking events 

Subscribing to start/stop speaking events, the speechEvent object (which is undefined) is trying to invoke to 'on' method. This prevents the correct behaviour of the stop/start speaking events.
pull/694/head
csantosm 2022-02-11 17:33:45 +01:00
parent f88ea86bed
commit af818b66f6
2 changed files with 10757 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10753
openvidu-browser/package-lock.json generated Normal file
View File

File diff suppressed because it is too large Load Diff

8
openvidu-browser/src/OpenVidu/Stream.ts
View File

@ -550,7 +550,7 @@ export class Stream {
*/
enableHarkSpeakingEvent(): void {
this.setHarkListenerIfNotExists();
if (!this.harkSpeakingEnabled) {
if (!this.harkSpeakingEnabled && !!this.speechEvent) {
this.harkSpeakingEnabled = true;
this.speechEvent.on('speaking', () => {
this.session.emitEvent('publisherStartSpeaking', [new PublisherSpeakingEvent(this.session, 'publisherStartSpeaking', this.connection, this.streamId)]);
@ -565,7 +565,7 @@ export class Stream {
*/
enableOnceHarkSpeakingEvent(): void {
this.setHarkListenerIfNotExists();
if (!this.harkSpeakingEnabledOnce) {
if (!this.harkSpeakingEnabledOnce && !!this.speechEvent) {
this.harkSpeakingEnabledOnce = true;
this.speechEvent.once('speaking', () => {
if (this.harkSpeakingEnabledOnce) {
@ -612,7 +612,7 @@ export class Stream {
*/
enableHarkStoppedSpeakingEvent(): void {
this.setHarkListenerIfNotExists();
if (!this.harkStoppedSpeakingEnabled) {
if (!this.harkStoppedSpeakingEnabled && !!this.speechEvent) {
this.harkStoppedSpeakingEnabled = true;
this.speechEvent.on('stopped_speaking', () => {
this.session.emitEvent('publisherStopSpeaking', [new PublisherSpeakingEvent(this.session, 'publisherStopSpeaking', this.connection, this.streamId)]);
@ -627,7 +627,7 @@ export class Stream {
*/
enableOnceHarkStoppedSpeakingEvent(): void {
this.setHarkListenerIfNotExists();
if (!this.harkStoppedSpeakingEnabledOnce) {
if (!this.harkStoppedSpeakingEnabledOnce && !!this.speechEvent) {
this.harkStoppedSpeakingEnabledOnce = true;
this.speechEvent.once('stopped_speaking', () => {
if (this.harkStoppedSpeakingEnabledOnce) {