From a92335b5beef08303525647cc937f1a11c8caea5 Mon Sep 17 00:00:00 2001 From: pabloFuente Date: Mon, 16 Nov 2020 14:04:18 +0100 Subject: [PATCH] openvidu-browser: allow screen sharing with Edge --- openvidu-browser/src/OpenVidu/OpenVidu.ts | 2 +- openvidu-browser/src/OpenViduInternal/Utils/Platform.ts | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/openvidu-browser/src/OpenVidu/OpenVidu.ts b/openvidu-browser/src/OpenVidu/OpenVidu.ts index 96beded8..9e98fecb 100644 --- a/openvidu-browser/src/OpenVidu/OpenVidu.ts +++ b/openvidu-browser/src/OpenVidu/OpenVidu.ts @@ -878,7 +878,7 @@ export class OpenVidu { // Screen sharing if (!this.checkScreenSharingCapabilities()) { - const error = new OpenViduError(OpenViduErrorName.SCREEN_SHARING_NOT_SUPPORTED, 'You can only screen share in desktop Chrome, Firefox, Opera, Safari (>=13.0) or Electron. Detected client: ' + platform.getName()); + const error = new OpenViduError(OpenViduErrorName.SCREEN_SHARING_NOT_SUPPORTED, 'You can only screen share in desktop Chrome, Firefox, Opera, Safari (>=13.0), Edge (>= 80) or Electron. Detected client: ' + platform.getName() + ' ' + platform.getVersion()); logger.error(error); reject(error); } else { diff --git a/openvidu-browser/src/OpenViduInternal/Utils/Platform.ts b/openvidu-browser/src/OpenViduInternal/Utils/Platform.ts index 814e2af4..a591b38e 100644 --- a/openvidu-browser/src/OpenViduInternal/Utils/Platform.ts +++ b/openvidu-browser/src/OpenViduInternal/Utils/Platform.ts @@ -146,17 +146,16 @@ export class PlatformUtils { */ public canScreenShare(): boolean { const version = platform?.version ? parseFloat(platform.version) : -1; - // Reject mobile devices if (this.isMobileDevice()) { return false; } - return ( this.isChromeBrowser() || this.isFirefoxBrowser() || this.isOperaBrowser() || this.isElectron() || + this.isEdgeBrowser() || (this.isSafariBrowser() && version >= 13) ); }