ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-browser: remove unused parameter in Publisher#getVideoDimensions

pull/721/head
pabloFuente 2022-05-10 15:45:43 +02:00
parent 46ba13410b
commit a38d6b4855
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openvidu-browser/src/OpenVidu/OpenVidu.ts
View File

@ -635,7 +635,7 @@ export class OpenVidu {
if (attempts > MAX_ATTEMPTS) { if (attempts > MAX_ATTEMPTS) {
clearTimeout(repeatUntilChangeOrMaxAttempts); clearTimeout(repeatUntilChangeOrMaxAttempts);
} }
publisher.getVideoDimensions(publisher.stream.getMediaStream()).then(newDimensions => { publisher.getVideoDimensions().then(newDimensions => {
if (newDimensions.width !== oldWidth || newDimensions.height !== oldHeight) { if (newDimensions.width !== oldWidth || newDimensions.height !== oldHeight) {
clearTimeout(repeatUntilChangeOrMaxAttempts); clearTimeout(repeatUntilChangeOrMaxAttempts);
this.sendVideoDimensionsChangedEvent(publisher, reason, oldWidth, oldHeight, newDimensions.width, newDimensions.height); this.sendVideoDimensionsChangedEvent(publisher, reason, oldWidth, oldHeight, newDimensions.width, newDimensions.height);

6
openvidu-browser/src/OpenVidu/Publisher.ts
View File

@ -438,7 +438,7 @@ export class Publisher extends StreamManager {
if (this.stream.isSendVideo()) { if (this.stream.isSendVideo()) {
// Has video track // Has video track
this.getVideoDimensions(mediaStream).then(dimensions => { this.getVideoDimensions().then(dimensions => {
this.stream.videoDimensions = { this.stream.videoDimensions = {
width: dimensions.width, width: dimensions.width,
height: dimensions.height height: dimensions.height
@ -670,7 +670,7 @@ export class Publisher extends StreamManager {
* and then try to use MediaStreamTrack.getSettingsMethod(). If not available, then we * and then try to use MediaStreamTrack.getSettingsMethod(). If not available, then we
* use the HTMLVideoElement properties videoWidth and videoHeight * use the HTMLVideoElement properties videoWidth and videoHeight
*/ */
getVideoDimensions(mediaStream: MediaStream): Promise<{ width: number, height: number }> { getVideoDimensions(): Promise<{ width: number, height: number }> {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
// Ionic iOS and Safari iOS supposedly require the video element to actually exist inside the DOM // Ionic iOS and Safari iOS supposedly require the video element to actually exist inside the DOM
@ -770,7 +770,7 @@ export class Publisher extends StreamManager {
mediaStream.removeTrack(removedTrack); mediaStream.removeTrack(removedTrack);
removedTrack.stop(); removedTrack.stop();
mediaStream.addTrack(track); mediaStream.addTrack(track);
if (track.kind === 'video' && this.stream.isLocalStreamPublished) { if (track.kind === 'video' && this.stream.isLocalStreamPublished && updateLastConstraints) {
this.openvidu.sendNewVideoDimensionsIfRequired(this, 'trackReplaced', 50, 30); this.openvidu.sendNewVideoDimensionsIfRequired(this, 'trackReplaced', 50, 30);
this.session.sendVideoData(this.stream.streamManager, 5, true, 5); this.session.sendVideoData(this.stream.streamManager, 5, true, 5);
} }