ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-server: avoid fatal error if an outdated version of openvidu-browser is in use by STT or broadcasting module

pull/803/head
pabloFuente 2023-04-03 19:52:21 +02:00
parent 16ec1c9480
commit a0e6b137cc
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
openvidu-server/src/main/java/io/openvidu/server/rpc/RpcHandler.java
View File

@ -941,12 +941,21 @@ public class RpcHandler extends DefaultJsonRpcHandler<JsonObject> {
try { try {
new VersionComparator().checkVersionCompatibility(clientVersion, serverVersion); new VersionComparator().checkVersionCompatibility(clientVersion, serverVersion);
} catch (VersionMismatchException e) { } catch (VersionMismatchException e) {
String outdatedModule = null;
if (participant.isRecorderParticipant())
outdatedModule = "COMPOSED recording layout";
else if (participant.isBroadcastParticipant())
outdatedModule = "broadcasting layout";
else if (participant.isSttParticipant())
outdatedModule = "Speech To Text module";
if (e.isIncompatible()) { if (e.isIncompatible()) {
if (participant.isRecorderParticipant()) { if (participant.isRecorderOrSttOrBroadcastParticipant()) {
log.error( log.error(
"The COMPOSED recording layout is using an incompatible version of openvidu-browser SDK ({}) for this OpenVidu deployment ({}). This may cause the system to malfunction", "The {} is using an incompatible version of openvidu-browser SDK ({}) for this OpenVidu deployment ({}). This may cause the system to malfunction",
clientVersion, serverVersion); outdatedModule, clientVersion, serverVersion);
} else { } else {
log.error( log.error(
"Participant {}{}{} has an incompatible version of openvidu-browser SDK ({}) for this OpenVidu deployment ({}). This may cause the system to malfunction", "Participant {}{}{} has an incompatible version of openvidu-browser SDK ({}) for this OpenVidu deployment ({}). This may cause the system to malfunction",
@ -962,12 +971,13 @@ public class RpcHandler extends DefaultJsonRpcHandler<JsonObject> {
} else { } else {
DefaultArtifactVersion v = new DefaultArtifactVersion(serverVersion); DefaultArtifactVersion v = new DefaultArtifactVersion(serverVersion);
if (participant.isRecorderParticipant()) { if (participant.isRecorderOrSttOrBroadcastParticipant()) {
log.warn( log.warn(
"The COMPOSED recording layout has an older version of openvidu-browser SDK ({}) for this OpenVidu deployment ({}). These versions are still compatible with each other, " "The {} has an older version of openvidu-browser SDK ({}) for this OpenVidu deployment ({}). These versions are still compatible with each other, "
+ "but client SDK must be updated as soon as possible to {}.x. This recording layout using openvidu-browser {} will become incompatible with the next release of openvidu-server", + "but client SDK must be updated as soon as possible to {}.x. This {} using openvidu-browser {} will become incompatible with the next release of openvidu-server",
clientVersion, serverVersion, (v.getMajorVersion() + "." + v.getMinorVersion()), outdatedModule, clientVersion, serverVersion,
clientVersion); (v.getMajorVersion() + "." + v.getMinorVersion()), outdatedModule, clientVersion);
} else { } else {
log.warn( log.warn(
"Participant {} with IP {} and platform {} has an older version of openvidu-browser SDK ({}) for this OpenVidu deployment ({}). " "Participant {} with IP {} and platform {} has an older version of openvidu-browser SDK ({}) for this OpenVidu deployment ({}). "