From 8edd8827caf5300f6b6ceacb0b34f28d948800c9 Mon Sep 17 00:00:00 2001
From: cruizba <carlos.ruizbal@gmail.com>
Date: Thu, 21 Apr 2022 18:36:33 +0200
Subject: [PATCH] deployment: Don't use /dev/random to generate coturn secret
 which produces a pipe error. Use shuf instead

---
 openvidu-server/docker/openvidu-server-pro/entrypoint.sh | 8 ++++----
 openvidu-server/docker/openvidu-server/entrypoint.sh     | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/openvidu-server/docker/openvidu-server-pro/entrypoint.sh b/openvidu-server/docker/openvidu-server-pro/entrypoint.sh
index 7f80edfa..f1b56ee4 100755
--- a/openvidu-server/docker/openvidu-server-pro/entrypoint.sh
+++ b/openvidu-server/docker/openvidu-server-pro/entrypoint.sh
@@ -18,7 +18,7 @@ if [[ -z "${COTURN_SHARED_SECRET_KEY}" ]]; then
         mkdir -p /run/secrets/coturn
 
         # Generate random coturn secret
-        RANDOM_COTURN_SECRET="$(tr -dc '[:alnum:]' </dev/urandom | head -c 35)"
+        RANDOM_COTURN_SECRET="$(shuf --echo --repeat --zero-terminated --head-count=35  {A..Z} {a..z} {0..9})"
 
         # Replace value and generate shared-secret-key file
         sed "s|{{COTURN_SHARED_SECRET_KEY}}|${RANDOM_COTURN_SECRET}|g" \
@@ -34,13 +34,13 @@ fi
 if [ -n "${WAIT_KIBANA_URL}" ]; then
   printf "\n"
   printf "\n  ======================================="
-  printf "\n  Waiting for Kibana service."
+  printf "\n      Waiting for Kibana service."
   printf "\n  ======================================="
   printf "\n"
 
-  until "$(curl --insecure --output /dev/null --silent --head --fail --max-time 10 --connect-timeout 10 "${WAIT_KIBANA_URL}")"
+  until curl --insecure --output /dev/null --silent --head --fail --max-time 10 --connect-timeout 10 "${WAIT_KIBANA_URL}" &> /dev/null
   do
-    printf "\n  Waiting for kibana in '%s' 'URL'. This may take some minutes, please be patient" "${WAIT_KIBANA_URL}"
+    printf "\n  Waiting for kibana in '%s' 'URL'. This may take some minutes, please be patient..." "${WAIT_KIBANA_URL}"
     sleep 1
   done
   printf "\n  ==== Kibana is Ready ===="
diff --git a/openvidu-server/docker/openvidu-server/entrypoint.sh b/openvidu-server/docker/openvidu-server/entrypoint.sh
index 7e110d11..c1451993 100644
--- a/openvidu-server/docker/openvidu-server/entrypoint.sh
+++ b/openvidu-server/docker/openvidu-server/entrypoint.sh
@@ -21,7 +21,7 @@ if [[ -z "${COTURN_SHARED_SECRET_KEY}" ]]; then
         mkdir -p /run/secrets/coturn
 
         # Generate random coturn secret
-        RANDOM_COTURN_SECRET="$(tr -dc '[:alnum:]' </dev/urandom | head -c 35)"
+        RANDOM_COTURN_SECRET="$(shuf --echo --repeat --zero-terminated --head-count=35  {A..Z} {a..z} {0..9})"
 
         # Replace value and generate shared-secret-key file
         sed "s|{{COTURN_SHARED_SECRET_KEY}}|${RANDOM_COTURN_SECRET}|g" \