ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-components: Avoided using await for returning a promise

pull/780/head
Carlos Santos 2023-02-10 15:28:45 +01:00
parent 68ccf49f29
commit 8cdd4dd751
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openvidu-components-angular/projects/openvidu-angular/src/lib/services/openvidu/openvidu.service.ts
View File

@ -270,7 +270,7 @@ export class OpenViduService {
mirror mirror
}; };
if (hasVideoDevices || hasAudioDevices) { if (hasVideoDevices || hasAudioDevices) {
const publisher = await this.initPublisher(undefined, properties); const publisher = await this.initPublisher(properties);
this.participantService.setMyCameraPublisher(publisher); this.participantService.setMyCameraPublisher(publisher);
this.participantService.updateLocalParticipant(); this.participantService.updateLocalParticipant();
return publisher; return publisher;
@ -282,9 +282,9 @@ export class OpenViduService {
/** /**
* @internal * @internal
*/ */
async initPublisher(targetElement: string | HTMLElement, properties: PublisherProperties): Promise<Publisher> { private async initPublisher(properties: PublisherProperties, targetElement?: string | HTMLElement): Promise<Publisher> {
this.log.d('Initializing publisher with properties: ', properties); this.log.d('Initializing publisher with properties: ', properties);
return await this.OV.initPublisherAsync(targetElement, properties); return this.OV.initPublisherAsync(targetElement, properties);
} }
/** /**
@ -407,7 +407,7 @@ export class OpenViduService {
publishAudio: hasAudio, publishAudio: hasAudio,
mirror: false mirror: false
}; };
const screenPublisher = await this.initPublisher(undefined, properties); const screenPublisher = await this.initPublisher(properties);
screenPublisher.once('accessAllowed', async () => { screenPublisher.once('accessAllowed', async () => {
// Listen to event fired when native stop button is clicked // Listen to event fired when native stop button is clicked