From 84864202aa86c2eeba621339768ef46296f256aa Mon Sep 17 00:00:00 2001
From: pabloFuente <pablofuenteperez@gmail.com>
Date: Tue, 27 Dec 2022 13:57:15 +0100
Subject: [PATCH] openvidu-testapp: fix broken checkboxes after Angular update

---
 .../publisher-properties-dialog.component.html | 12 ++++++------
 .../recording-properties.component.html        |  2 +-
 .../scenario-properties-dialog.component.html  |  4 ++--
 .../openvidu-instance.component.html           | 18 +++++++++---------
 4 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/openvidu-testapp/src/app/components/dialogs/publisher-properties-dialog/publisher-properties-dialog.component.html b/openvidu-testapp/src/app/components/dialogs/publisher-properties-dialog/publisher-properties-dialog.component.html
index 2044560c..8720d7fb 100644
--- a/openvidu-testapp/src/app/components/dialogs/publisher-properties-dialog/publisher-properties-dialog.component.html
+++ b/openvidu-testapp/src/app/components/dialogs/publisher-properties-dialog/publisher-properties-dialog.component.html
@@ -1,14 +1,14 @@
 <div>
     <h2 mat-dialog-title>Publisher properties</h2>
     <mat-dialog-content>
-        <mat-checkbox (click)="toggleAudio()" [checked]="publisherProperties.audioSource !== false">Audio
+        <mat-checkbox (change)="toggleAudio()" [checked]="publisherProperties.audioSource !== false">Audio
         </mat-checkbox>
-        <mat-checkbox (click)="toggleVideo()" [checked]="publisherProperties.videoSource !== false">Video
+        <mat-checkbox (change)="toggleVideo()" [checked]="publisherProperties.videoSource !== false">Video
         </mat-checkbox>
-        <mat-checkbox [(ngModel)]="publisherProperties.publishAudio" (click)="publisherProperties.publishAudio = !publisherProperties.publishAudio">Publish audio</mat-checkbox>
-        <mat-checkbox [(ngModel)]="publisherProperties.publishVideo" (click)="publisherProperties.publishVideo = !publisherProperties.publishVideo">Publish video</mat-checkbox>
-        <mat-checkbox [(ngModel)]="publisherProperties.mirror" (click)="publisherProperties.mirror = !publisherProperties.mirror">Mirror</mat-checkbox>
-        <mat-checkbox [(ngModel)]="publisherProperties.videoSimulcast" (click)="publisherProperties.videoSimulcast = !publisherProperties.videoSimulcast">Video Simulcast</mat-checkbox>
+        <mat-checkbox [checked]="publisherProperties.publishAudio" (change)="publisherProperties.publishAudio = !publisherProperties.publishAudio">Publish audio</mat-checkbox>
+        <mat-checkbox [checked]="publisherProperties.publishVideo" (change)="publisherProperties.publishVideo = !publisherProperties.publishVideo">Publish video</mat-checkbox>
+        <mat-checkbox [checked]="publisherProperties.mirror" (change)="publisherProperties.mirror = !publisherProperties.mirror">Mirror</mat-checkbox>
+        <mat-checkbox [checked]="publisherProperties.videoSimulcast" (change)="publisherProperties.videoSimulcast = !publisherProperties.videoSimulcast">Video Simulcast</mat-checkbox>
         <mat-divider></mat-divider>
         <mat-form-field>
             <input matInput placeholder="Audio source" [(ngModel)]="audioSource" [disabled]="(publisherProperties.audioSource === false)">
diff --git a/openvidu-testapp/src/app/components/dialogs/recording-properties/recording-properties.component.html b/openvidu-testapp/src/app/components/dialogs/recording-properties/recording-properties.component.html
index f9fce764..bcfa6e75 100644
--- a/openvidu-testapp/src/app/components/dialogs/recording-properties/recording-properties.component.html
+++ b/openvidu-testapp/src/app/components/dialogs/recording-properties/recording-properties.component.html
@@ -11,7 +11,7 @@
         </mat-option>
       </mat-select>
     </mat-form-field>
-    <mat-form-field class="inner-text-input" [style.fontSize.px]=14>
+    <mat-form-field *ngIf="!!recordingProperties.mediaNode" class="inner-text-input" [style.fontSize.px]=14>
       <input matInput id="recording-media-node-field" placeholder="Media Node"
         [(ngModel)]="recordingProperties.mediaNode.id">
     </mat-form-field>
diff --git a/openvidu-testapp/src/app/components/dialogs/scenario-properties-dialog/scenario-properties-dialog.component.html b/openvidu-testapp/src/app/components/dialogs/scenario-properties-dialog/scenario-properties-dialog.component.html
index 424d8d6c..50f0a2ad 100644
--- a/openvidu-testapp/src/app/components/dialogs/scenario-properties-dialog/scenario-properties-dialog.component.html
+++ b/openvidu-testapp/src/app/components/dialogs/scenario-properties-dialog/scenario-properties-dialog.component.html
@@ -21,8 +21,8 @@
             </div>
         </div>
         <label class="conf-label">Publisher configuration</label>
-        <mat-checkbox (click)="toggleAudio()" [checked]="publisherProperties.audioSource !== false">Audio</mat-checkbox>
-        <mat-checkbox (click)="toggleVideo()" [checked]="publisherProperties.videoSource !== false">Video</mat-checkbox>
+        <mat-checkbox (change)="toggleAudio()" [checked]="publisherProperties.audioSource !== false">Audio</mat-checkbox>
+        <mat-checkbox (change)="toggleVideo()" [checked]="publisherProperties.videoSource !== false">Video</mat-checkbox>
         <mat-divider></mat-divider>
         <mat-form-field>
             <input matInput placeholder="Audio source" [(ngModel)]="audioSource" [disabled]="(publisherProperties.audioSource === false)">
diff --git a/openvidu-testapp/src/app/components/openvidu-instance/openvidu-instance.component.html b/openvidu-testapp/src/app/components/openvidu-instance/openvidu-instance.component.html
index 9caaa6a2..e24b5d77 100644
--- a/openvidu-testapp/src/app/components/openvidu-instance/openvidu-instance.component.html
+++ b/openvidu-testapp/src/app/components/openvidu-instance/openvidu-instance.component.html
@@ -39,9 +39,9 @@
 
           <div class="join-publish-div">
             <button class="join-btn" mat-button (click)="joinSession()" [disabled]="session">JOIN</button>
-            <mat-checkbox class="subscribe-checkbox" name="subscribeTo" (click)="toggleSubscribeTo()"
+            <mat-checkbox class="subscribe-checkbox" name="subscribeTo" (change)="toggleSubscribeTo()"
               [checked]="subscribeTo" [disabled]="session">Subscribe</mat-checkbox>
-            <mat-checkbox class="publish-checkbox" name="publishTo" (click)="togglePublishTo()" [checked]="publishTo"
+            <mat-checkbox class="publish-checkbox" name="publishTo" (change)="togglePublishTo()" [checked]="publishTo"
               [disabled]="session">Publish</mat-checkbox>
           </div>
 
@@ -51,10 +51,10 @@
               <div>
                 <h4>Send</h4>
                 <div>
-                  <mat-checkbox class="send-audio-checkbox" name="sendAudio" (click)="toggleSendAudio()"
+                  <mat-checkbox class="send-audio-checkbox" name="sendAudio" (change)="toggleSendAudio()"
                     [checked]="publisherProperties.audioSource !== false" [disabled]="session || !publishTo">Audio
                   </mat-checkbox>
-                  <mat-checkbox class="send-video-checkbox" name="sendVideo" (click)="toggleSendVideo()"
+                  <mat-checkbox class="send-video-checkbox" name="sendVideo" (change)="toggleSendVideo()"
                     [checked]="publisherProperties.videoSource !== false" [disabled]="session || !publishTo">Video
                   </mat-checkbox>
                 </div>
@@ -63,12 +63,12 @@
                 <h4>Enter active</h4>
                 <div>
                   <mat-checkbox class="active-audio-checkbox" name="activeAudio"
-                    [(ngModel)]="publisherProperties.publishAudio"
-                    (click)="publisherProperties.publishAudio = !publisherProperties.publishAudio"
+                    [checked]="publisherProperties.publishAudio"
+                    (change)="publisherProperties.publishAudio = !publisherProperties.publishAudio"
                     [disabled]="session || !publishTo">Audio</mat-checkbox>
                   <mat-checkbox class="active-video-checkbox" name="activeVideo"
-                    [(ngModel)]="publisherProperties.publishVideo"
-                    (click)="publisherProperties.publishVideo = !publisherProperties.publishVideo"
+                    [checked]="publisherProperties.publishVideo"
+                    (change)="publisherProperties.publishVideo = !publisherProperties.publishVideo"
                     [disabled]="session || !publishTo">Video</mat-checkbox>
                 </div>
               </div>
@@ -85,7 +85,7 @@
                 </div>
               </mat-radio-group>
               <mat-checkbox class="subscribe-remote-check" name="subscribeToRemote"
-                (click)="subscribeToRemote = !subscribeToRemote" [disabled]="!publishTo || session"
+                (change)="subscribeToRemote = !subscribeToRemote" [disabled]="!publishTo || session"
                 [checked]="publishTo && subscribeToRemote">Subscribe
                 <br>to remote</mat-checkbox>
             </div>