ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

569 - Session: adding fallback values (0) to the height and width in case the stream's videoDimensions are not set and adding safe-check in case videoActive or audioActive were not set

pull/570/head
Amauri de Melo Junior 2020-11-26 14:31:04 -03:00
parent 5d479dc645
commit 7a0592a326
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openvidu-browser/src/OpenVidu/Session.ts
View File

@ -1206,10 +1206,10 @@ export class Session extends EventDispatcher {
} else if (platform.isFirefoxBrowser() || platform.isFirefoxMobileBrowser() || platform.isIonicIos() || platform.isReactNative()) { } else if (platform.isFirefoxBrowser() || platform.isFirefoxMobileBrowser() || platform.isIonicIos() || platform.isReactNative()) {
// Basic version for Firefox and Ionic iOS. They do not support stats // Basic version for Firefox and Ionic iOS. They do not support stats
this.openvidu.sendRequest('videoData', { this.openvidu.sendRequest('videoData', {
height: streamManager.stream.videoDimensions.height, height: streamManager.stream.videoDimensions?.height || 0,
width: streamManager.stream.videoDimensions.width, width: streamManager.stream.videoDimensions?.width || 0,
videoActive: streamManager.stream.videoActive, videoActive: streamManager.stream.videoActive != null ? streamManager.stream.videoActive : false,
audioActive: streamManager.stream.audioActive audioActive: streamManager.stream.audioActive != null ? streamManager.stream.audioActive : false
}, (error, response) => { }, (error, response) => {
if (error) { if (error) {
logger.error("Error sending 'videoData' event", error); logger.error("Error sending 'videoData' event", error);