From 77bba7e58771246e5700bafc89b4e4c8f8475953 Mon Sep 17 00:00:00 2001 From: Carlos Santos <4a.santos@gmail.com> Date: Wed, 21 May 2025 12:06:36 +0200 Subject: [PATCH] ov-components: uncomment screen track replacement test --- .../openvidu-components-angular-tests.yml | 2 +- .../e2e/media-devices.test.ts | 36 +++++++++---------- 2 files changed, 18 insertions(+), 20 deletions(-) diff --git a/.github/workflows/openvidu-components-angular-tests.yml b/.github/workflows/openvidu-components-angular-tests.yml index eff4dfc0..14dc7b43 100644 --- a/.github/workflows/openvidu-components-angular-tests.yml +++ b/.github/workflows/openvidu-components-angular-tests.yml @@ -255,7 +255,7 @@ jobs: e2e_media_devices: needs: test_setup - name: Mmedia devices E2E + name: Media devices E2E runs-on: ubuntu-latest steps: - name: Checkout Repository diff --git a/openvidu-components-angular/e2e/media-devices.test.ts b/openvidu-components-angular/e2e/media-devices.test.ts index 8f118727..b188f653 100644 --- a/openvidu-components-angular/e2e/media-devices.test.ts +++ b/openvidu-components-angular/e2e/media-devices.test.ts @@ -79,33 +79,31 @@ describe('Media Devices: Virtual Device Replacement and Permissions Handling', ( expect(videoLabel).toEqual('fake_device_0'); }); - // TODO: Uncommented when Livekit allows to replace the screen track - // it('should replace the screen track with a custom virtual device', async () => { - // const script = 'return document.getElementsByClassName("OV_video-element screen-type")[0].srcObject.getVideoTracks()[0].label;'; + it('should replace the screen track with a custom virtual device', async () => { + const script = 'return document.getElementsByClassName("OV_video-element screen-type")[0].srcObject.getVideoTracks()[0].label;'; - // await browser.get(`${url}&prejoin=false&fakeDevices=true`); + await browser.get(`${url}&prejoin=false&fakeDevices=true`); - // await utils.checkLayoutPresent(); - // await utils.checkToolbarIsPresent(); + await utils.checkLayoutPresent(); + await utils.checkToolbarIsPresent(); - // await utils.clickOn('#screenshare-btn'); + await utils.clickOn('#screenshare-btn'); - // await browser.sleep(500); + await browser.sleep(500); - // let screenLabel = await browser.executeScript(script); - // expect(screenLabel).not.toEqual('custom_fake_screen'); + let screenLabel = await browser.executeScript(script); + expect(screenLabel).not.toEqual('custom_fake_screen'); - // await utils.clickOn('#video-settings-btn-SCREEN'); - // await browser.sleep(500); + await utils.clickOn('#screenshare-btn'); + await browser.sleep(500); - // await utils.waitForElement('.video-settings-menu'); - // const replaceBtn = await utils.waitForElement('#replace-screen-button'); - // await replaceBtn.sendKeys(Key.ENTER); + await utils.waitForElement('#replace-screen-button'); + await utils.clickOn('#replace-screen-button'); + await browser.sleep(1000); - // await browser.sleep(1000); - // screenLabel = await browser.executeScript(script); - // expect(screenLabel).to.be.toEqual('custom_fake_screen'); - // }); + screenLabel = await browser.executeScript(script); + expect(screenLabel).toEqual('custom_fake_screen'); + }); }); describe('Media Devices: UI Behavior Without Media Device Permissions', () => {