From 71c5409b0523bf5cf31fcc98d78e248a4dd9f086 Mon Sep 17 00:00:00 2001 From: pabloFuente Date: Tue, 22 Sep 2020 10:34:51 +0200 Subject: [PATCH] openvidu-server: return 501 for any recording REST method if recording disabled --- .../server/rest/SessionRestController.java | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/openvidu-server/src/main/java/io/openvidu/server/rest/SessionRestController.java b/openvidu-server/src/main/java/io/openvidu/server/rest/SessionRestController.java index a5bbcd39..a8f8adf7 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/rest/SessionRestController.java +++ b/openvidu-server/src/main/java/io/openvidu/server/rest/SessionRestController.java @@ -598,6 +598,11 @@ public class SessionRestController { log.info("REST API: POST /api/recordings/stop/{}", recordingId); + if (!this.openviduConfig.isRecordingModuleEnabled()) { + // OpenVidu Server configuration property "OPENVIDU_RECORDING" is set to false + return new ResponseEntity<>(HttpStatus.NOT_IMPLEMENTED); + } + Recording recording = recordingManager.getStartedRecording(recordingId); if (recording == null) { @@ -634,6 +639,11 @@ public class SessionRestController { log.info("REST API: GET /api/recordings/{}", recordingId); + if (!this.openviduConfig.isRecordingModuleEnabled()) { + // OpenVidu Server configuration property "OPENVIDU_RECORDING" is set to false + return new ResponseEntity<>(HttpStatus.NOT_IMPLEMENTED); + } + try { Recording recording = this.recordingManager.getRecording(recordingId); if (io.openvidu.java.client.Recording.Status.started.equals(recording.getStatus()) @@ -651,6 +661,11 @@ public class SessionRestController { log.info("REST API: GET /api/recordings"); + if (!this.openviduConfig.isRecordingModuleEnabled()) { + // OpenVidu Server configuration property "OPENVIDU_RECORDING" is set to false + return new ResponseEntity<>(HttpStatus.NOT_IMPLEMENTED); + } + Collection recordings = this.recordingManager.getAllRecordings(); JsonObject json = new JsonObject(); JsonArray jsonArray = new JsonArray(); @@ -671,6 +686,11 @@ public class SessionRestController { log.info("REST API: DELETE /api/recordings/{}", recordingId); + if (!this.openviduConfig.isRecordingModuleEnabled()) { + // OpenVidu Server configuration property "OPENVIDU_RECORDING" is set to false + return new ResponseEntity<>(HttpStatus.NOT_IMPLEMENTED); + } + return new ResponseEntity<>(this.recordingManager.deleteRecordingFromHost(recordingId, false)); }