From 6d018de09d8b0f639b160d99f9c5ac74be190afe Mon Sep 17 00:00:00 2001
From: cruizba <carlos.ruizbal@gmail.com>
Date: Fri, 25 Feb 2022 20:01:51 +0100
Subject: [PATCH] deployment: external-turn - More explanatory comments at .env
 and certbot.sh

---
 openvidu-server/deployments/external-turn/.env       | 4 ++--
 openvidu-server/deployments/external-turn/certbot.sh | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/openvidu-server/deployments/external-turn/.env b/openvidu-server/deployments/external-turn/.env
index 121ef548..475d7417 100644
--- a/openvidu-server/deployments/external-turn/.env
+++ b/openvidu-server/deployments/external-turn/.env
@@ -1,10 +1,10 @@
 # The domain which is pointing to the public ip of the machine.
 TURN_DOMAIN_NAME=
 
-# If CERTIFICATE_TYPE=letsencrypt, you need to configure a valid email for notifications
+# Valid certificate for letsencrypt
 LETSENCRYPT_EMAIL=
 
-# TURN fixed credentials. This parameter purpose is to support "TURN Server REST API".
+# TURN shared key with OpenVidu. This parameter purpose is to support "TURN Server REST API".
 # See:
 #   - https://tools.ietf.org/html/draft-uberti-behave-turn-rest-00
 #   - https://www.ietf.org/proceedings/87/slides/slides-87-behave-10.pdf
diff --git a/openvidu-server/deployments/external-turn/certbot.sh b/openvidu-server/deployments/external-turn/certbot.sh
index 86593264..e42d3f08 100755
--- a/openvidu-server/deployments/external-turn/certbot.sh
+++ b/openvidu-server/deployments/external-turn/certbot.sh
@@ -16,6 +16,7 @@ while :; do
     	CERTIFICATES_FOUND=true
     fi
     certbot "$@";
+    # Let coturn to load letsencrypt certificates
     chmod 777 -R /etc/letsencrypt;
     TURN_PID=$(pgrep -n '^turnserver$')
     if [ -n "${TURN_PID}" ]; then
@@ -24,7 +25,7 @@ while :; do
             kill -KILL "${TURN_PID}"
         else
             # Send SIGUSR2 signal to coturn to restart process with new certificates
-            # As certbot is running in the same namespace as coturn (#pid:container:coturn),
+            # As certbot is running in the same namespace as coturn,
             # it will send the signal to the coturn process to reload the certificates
             kill -USR2 "${TURN_PID}"
         fi