From 5b79f9a0a1fe652c1eb0465a8db663fe1a381cd8 Mon Sep 17 00:00:00 2001 From: Juan Navarro Date: Wed, 8 Sep 2021 11:27:52 +0200 Subject: [PATCH] recording: improve Error event logs Make the logs more descriptive and use the same structure for both of them in CompositeWrapper and SingleStreamRecordingService. --- .../java/io/openvidu/server/recording/CompositeWrapper.java | 6 +++++- .../recording/service/SingleStreamRecordingService.java | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/openvidu-server/src/main/java/io/openvidu/server/recording/CompositeWrapper.java b/openvidu-server/src/main/java/io/openvidu/server/recording/CompositeWrapper.java index 9b7c80f9..7138e10c 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/recording/CompositeWrapper.java +++ b/openvidu-server/src/main/java/io/openvidu/server/recording/CompositeWrapper.java @@ -80,7 +80,11 @@ public class CompositeWrapper { this.recorderEndpoint.addErrorListener(new EventListener() { @Override public void onEvent(ErrorEvent event) { - log.error(event.getErrorCode() + " " + event.getDescription()); + final String msg = "Event [" + event.getType() + "] endpoint: " + + recorderEndpoint.getName() + " | errorCode: " + event.getErrorCode() + + " | description: " + event.getDescription() + " | timestamp: " + + event.getTimestampMillis(); + log.error(msg); } }); diff --git a/openvidu-server/src/main/java/io/openvidu/server/recording/service/SingleStreamRecordingService.java b/openvidu-server/src/main/java/io/openvidu/server/recording/service/SingleStreamRecordingService.java index a81354f3..26bd2c74 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/recording/service/SingleStreamRecordingService.java +++ b/openvidu-server/src/main/java/io/openvidu/server/recording/service/SingleStreamRecordingService.java @@ -262,7 +262,11 @@ public class SingleStreamRecordingService extends RecordingService { recorder.addErrorListener(new EventListener() { @Override public void onEvent(ErrorEvent event) { - log.error(event.getErrorCode() + " " + event.getDescription()); + final String msg = "Event [" + event.getType() + "] endpoint: " + + recorder.getName() + " | errorCode: " + event.getErrorCode() + + " | description: " + event.getDescription() + " | timestamp: " + + event.getTimestampMillis(); + log.error(msg); } });