From 57f30b54beafe25f64f22b9ae7fb72c7f11a3c14 Mon Sep 17 00:00:00 2001 From: pabloFuente Date: Sun, 15 Nov 2020 23:24:55 +0100 Subject: [PATCH] openvidu-browser: fix Edge support --- openvidu-browser/src/OpenVidu/OpenVidu.ts | 12 ++++++------ .../src/OpenViduInternal/Utils/Platform.ts | 8 ++++++++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/openvidu-browser/src/OpenVidu/OpenVidu.ts b/openvidu-browser/src/OpenVidu/OpenVidu.ts index d4f01140..96beded8 100644 --- a/openvidu-browser/src/OpenVidu/OpenVidu.ts +++ b/openvidu-browser/src/OpenVidu/OpenVidu.ts @@ -343,11 +343,11 @@ export class OpenVidu { } // Accept: Chrome (desktop and Android), Firefox (desktop and Android), Opera (desktop and Android), - // Safari (OSX and iOS), Ionic (Android and iOS), Samsung Internet Browser (Android) - if (platform.isSafariBrowser() || platform.isChromeBrowser() || platform.isChromeMobileBrowser() || - platform.isFirefoxBrowser() || platform.isFirefoxMobileBrowser() || platform.isOperaBrowser() || - platform.isOperaMobileBrowser() || platform.isAndroidBrowser() || platform.isElectron() || - platform.isSamsungBrowser() + // Safari (OSX and iOS), Edge Chromium (>= 80), Ionic (Android and iOS), Samsung Internet Browser (Android) + if (platform.isChromeBrowser() || platform.isChromeMobileBrowser() || + platform.isFirefoxBrowser() || platform.isFirefoxMobileBrowser() || platform.isOperaBrowser() || + platform.isOperaMobileBrowser() || platform.isSafariBrowser() || platform.isEdgeBrowser() || + platform.isAndroidBrowser() || platform.isElectron() || platform.isSamsungBrowser() ) { return 1; } @@ -1047,4 +1047,4 @@ export class OpenVidu { (platform.isElectron() && videoSource.startsWith('screen:')) } - } \ No newline at end of file +} \ No newline at end of file diff --git a/openvidu-browser/src/OpenViduInternal/Utils/Platform.ts b/openvidu-browser/src/OpenViduInternal/Utils/Platform.ts index 96f429f4..814e2af4 100644 --- a/openvidu-browser/src/OpenViduInternal/Utils/Platform.ts +++ b/openvidu-browser/src/OpenViduInternal/Utils/Platform.ts @@ -57,6 +57,14 @@ export class PlatformUtils { return platform.name === "Opera Mobile"; } + /** + * @hidden + */ + public isEdgeBrowser(): boolean { + const version = platform?.version ? parseFloat(platform.version) : -1; + return platform.name === "Microsoft Edge" && version >= 80; + } + /** * @hidden */