ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ov-components: rename redirectOnLeaves to redirectToHomeOnLeaves for clarity and update related logic

master
Carlos Santos 2025-05-23 11:09:07 +02:00
parent b6f242107e
commit 549a822491
2 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openvidu-components-angular/e2e/events.test.ts
View File

@ -599,7 +599,7 @@ describe('Testing videoconference EVENTS', () => {
expect(await utils.isPresent('#onReadyToJoin')).toBeFalse();
});
// * PUBLISHER EVENTS
// PARTICIPANT EVENTS
it('should receive onParticipantCreated event from LOCAL participant', async () => {
const participantName = 'TEST_USER';
@ -609,7 +609,7 @@ describe('Testing videoconference EVENTS', () => {
});
it('should receive the onParticipantLeft event', async () => {
await browser.get(`${url}&prejoin=false&redirect=false`);
await browser.get(`${url}&prejoin=false&redirectToHome=false`);
await utils.checkSessionIsPresent();

23
openvidu-components-angular/src/app/openvidu-call/call.component.ts
View File

@ -60,7 +60,7 @@ export class CallComponent implements OnInit {
activitiesPanelBroadcastingActivity: boolean = true;
toolbarSettingsButton: boolean = true;
fakeDevices: boolean = false;
private redirectOnLeaves: boolean = true;
private redirectToHomeOnLeaves: boolean = true;
private staticVideos = [
'https://videos.pexels.com/video-files/4089575/4089575-hd_1280_720_50fps.mp4',
@ -142,10 +142,10 @@ export class CallComponent implements OnInit {
if (params['fakeDevices'] !== undefined) this.fakeDevices = params['fakeDevices'] === 'true';
if (params['redirect'] === undefined) {
this.redirectOnLeaves = true;
if (params['redirectToHome'] === undefined) {
this.redirectToHomeOnLeaves = true;
} else {
this.redirectOnLeaves = params['redirect'] === 'true';
this.redirectToHomeOnLeaves = params['redirectToHome'] === 'true';
}
this.configReady = true;
@ -177,7 +177,7 @@ export class CallComponent implements OnInit {
async onParticipantLeft(event: ParticipantLeftEvent) {
this.appendElement('onParticipantLeft');
console.warn('VC PARTICIPANT LEFT', event);
if (this.redirectOnLeaves) await this.router.navigate(['/']);
if (this.redirectToHomeOnLeaves) await this.router.navigate(['/']);
}
onRoomCreated(room: Room) {
@ -363,11 +363,16 @@ export class CallComponent implements OnInit {
}
private appendElement(id: string) {
var eventsDiv = document.getElementById('events');
eventsDiv?.setAttribute('style', 'position: absolute;');
var element = document.createElement('div');
const eventsDiv = document.getElementById('events');
if (!eventsDiv) {
console.error('No events div found');
return;
}
eventsDiv.setAttribute('style', 'position: absolute;');
const element = document.createElement('div');
element.setAttribute('id', id);
element.setAttribute('style', 'height: 1px;');
eventsDiv?.appendChild(element);
eventsDiv.appendChild(element);
}
}