From 53d54a682e401dc1a4c80d1fcb37ac02b605331e Mon Sep 17 00:00:00 2001 From: csantosm <4a.santos@gmail.com> Date: Thu, 7 Jul 2022 17:47:27 +0200 Subject: [PATCH] openvidu-components: Removed unnecessary code after fixed hark openvidu-browser hark events bug has been fixed so it is not necessary to resubscribe again after audio track is replaced. --- .../audio-wave/audio-wave.component.ts | 20 +------------------ 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/openvidu-components-angular/projects/openvidu-angular/src/lib/components/audio-wave/audio-wave.component.ts b/openvidu-components-angular/projects/openvidu-angular/src/lib/components/audio-wave/audio-wave.component.ts index a84d9a50..a19edbdb 100644 --- a/openvidu-components-angular/projects/openvidu-angular/src/lib/components/audio-wave/audio-wave.component.ts +++ b/openvidu-components-angular/projects/openvidu-angular/src/lib/components/audio-wave/audio-wave.component.ts @@ -1,5 +1,5 @@ import { Component, Input, OnDestroy, OnInit } from '@angular/core'; -import { PublisherSpeakingEvent, StreamManager, StreamPropertyChangedEvent } from 'openvidu-browser'; +import { PublisherSpeakingEvent, StreamManager } from 'openvidu-browser'; /** * @internal @@ -18,25 +18,12 @@ export class AudioWaveComponent implements OnInit, OnDestroy { ngOnInit(): void { this.subscribeSpeakingEvents(); - this.subscribeToStreamPropertyChanged(); } ngOnDestroy(): void { this.unsubscribeSpeakingEvents(); - this.unsubscribePropertyChangedEvents(); } - private subscribeToStreamPropertyChanged() { - if (this.streamManager) { - this.streamManager.on('streamPropertyChanged', (event: StreamPropertyChangedEvent) => { - if (event.reason === 'trackReplaced' && event.changedProperty === 'audioActive') { - // TODO: When the audio track is replaced, the startSpeakingEvents is not fired by openvidu-browser - this.unsubscribeSpeakingEvents(); - this.subscribeSpeakingEvents(); - } - }); - } - } private subscribeSpeakingEvents() { if (this.streamManager) { @@ -51,9 +38,4 @@ export class AudioWaveComponent implements OnInit, OnDestroy { this.streamManager.off('publisherStopSpeaking'); } } - private unsubscribePropertyChangedEvents() { - if (this.streamManager) { - this.streamManager.off('streamPropertyChanged'); - } - } }