From 4837c1402d79043b88ab4b1987765a4eedaab658 Mon Sep 17 00:00:00 2001 From: pabloFuente Date: Fri, 27 Apr 2018 11:43:21 +0200 Subject: [PATCH] openvidu-browser: links added to Docs in deprecation warnings --- .../lib/OpenViduInternal/VersionAdapter.js | 4 +-- .../OpenViduInternal/VersionAdapter.js.map | 2 +- .../src/OpenViduInternal/VersionAdapter.ts | 4 +-- .../openvidu-instance.component.ts | 25 ++++++++----------- 4 files changed, 16 insertions(+), 19 deletions(-) diff --git a/openvidu-browser/lib/OpenViduInternal/VersionAdapter.js b/openvidu-browser/lib/OpenViduInternal/VersionAdapter.js index ffda2dbe..33460594 100644 --- a/openvidu-browser/lib/OpenViduInternal/VersionAdapter.js +++ b/openvidu-browser/lib/OpenViduInternal/VersionAdapter.js @@ -19,7 +19,7 @@ exports.__esModule = true; var VideoInsertMode_1 = require("./Enums/VideoInsertMode"); function solveIfCallback(methodName, completionHandler, promise) { if (!!completionHandler) { - console.warn("DEPRECATION WANING: In future releases the 'completionHandler' parameter will be removed from method '" + methodName + "'. Please, refactor your callbacks to Promise API"); + console.warn("DEPRECATION WANING: In future releases the 'completionHandler' parameter will be removed from method '" + methodName + "'. Refactor your callbacks to Promise API (see http://openvidu.io/api/openvidu-browser/index.html)"); } return new Promise(function (resolve, reject) { if (!!completionHandler && typeof completionHandler === 'function') { @@ -46,7 +46,7 @@ function adaptPublisherProperties(properties) { 'videoActive' in properties || 'quality' in properties || 'screen' in properties) { - console.warn("DEPRECATION WANING: In future releases the properties passed to 'OpenVidu.initPublisher' method must match PublisherProperties interface. See http://openvidu.io"); + console.warn("DEPRECATION WANING: In future releases the properties passed to 'OpenVidu.initPublisher' method must match PublisherProperties interface (see http://openvidu.io/api/openvidu-browser/interfaces/publisherproperties.html)"); } var scr = (typeof properties.screen !== 'undefined' && properties.screen === true); var res = ''; diff --git a/openvidu-browser/lib/OpenViduInternal/VersionAdapter.js.map b/openvidu-browser/lib/OpenViduInternal/VersionAdapter.js.map index 756078e0..ae0b234c 100644 --- a/openvidu-browser/lib/OpenViduInternal/VersionAdapter.js.map +++ b/openvidu-browser/lib/OpenViduInternal/VersionAdapter.js.map @@ -1 +1 @@ -{"version":3,"file":"VersionAdapter.js","sourceRoot":"","sources":["../../src/OpenViduInternal/VersionAdapter.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;GAeG;;AAGH,2DAA0D;AAE1D,yBAAgC,UAAkB,EAAE,iBAAmE,EAAE,OAAqB;IAE1I,IAAI,CAAC,CAAC,iBAAiB,EAAE;QACrB,OAAO,CAAC,IAAI,CAAC,wGAAwG,GAAG,UAAU,GAAG,mDAAmD,CAAC,CAAC;KAC7L;IAED,OAAO,IAAI,OAAO,CAAC,UAAC,OAAO,EAAE,MAAM;QAC/B,IAAI,CAAC,CAAC,iBAAiB,IAAI,OAAO,iBAAiB,KAAK,UAAU,EAAE;YAChE,OAAO,CAAC,IAAI,CAAC;gBACT,iBAAiB,CAAC,SAAS,CAAC,CAAC;YACjC,CAAC,CAAC,CAAC,OAAK,CAAA,CAAC,UAAA,KAAK;gBACV,iBAAiB,CAAC,KAAK,CAAC,CAAC;YAC7B,CAAC,CAAC,CAAC;SACN;aAAM;YACH,OAAO,CAAC,IAAI,CAAC;gBACT,OAAA,OAAO,EAAE;YAAT,CAAS,CACZ,CAAC,OAAK,CAAA,CAAC,UAAA,KAAK;gBACT,OAAA,MAAM,CAAC,KAAK,CAAC;YAAb,CAAa,CAChB,CAAC;SACL;IACL,CAAC,CAAC,CAAC;AACP,CAAC;AArBD,0CAqBC;AAED,kCAAyC,UAAe;IAEpD,IACI,OAAO,IAAI,UAAU;QACrB,OAAO,IAAI,UAAU;QACrB,aAAa,IAAI,UAAU;QAC3B,aAAa,IAAI,UAAU;QAC3B,SAAS,IAAI,UAAU;QACvB,QAAQ,IAAI,UAAU,EACxB;QACE,OAAO,CAAC,IAAI,CAAC,kKAAkK,CAAC,CAAC;KACpL;IAED,IAAM,GAAG,GAAY,CAAC,OAAO,UAAU,CAAC,MAAM,KAAK,WAAW,IAAI,UAAU,CAAC,MAAM,KAAK,IAAI,CAAC,CAAC;IAC9F,IAAI,GAAG,GAAG,EAAE,CAAC;IACb,IAAI,OAAO,UAAU,CAAC,OAAO,KAAK,QAAQ,EAAE;QACxC,QAAQ,UAAU,CAAC,OAAO,EAAE;YACxB,KAAK,KAAK;gBACN,GAAG,GAAG,SAAS,CAAC;gBAChB,MAAM;YACV,KAAK,QAAQ;gBACT,GAAG,GAAG,SAAS,CAAC;gBAChB,MAAM;YACV,KAAK,MAAM;gBACP,GAAG,GAAG,UAAU,CAAC;gBACjB,MAAM;SACb;KACJ;IAED,IAAM,mBAAmB,GAAG;QACxB,WAAW,EAAE,CAAC,OAAO,UAAU,CAAC,KAAK,KAAK,WAAW,IAAI,UAAU,CAAC,KAAK,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,WAAW,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC,CAAC,SAAS,CAAC;QACrL,SAAS,EAAE,CAAC,OAAO,UAAU,CAAC,SAAS,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS;QAC3F,UAAU,EAAE,CAAC,OAAO,UAAU,CAAC,UAAU,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,CAAC,iCAAe,CAAC,MAAM;QAC3G,MAAM,EAAE,CAAC,OAAO,UAAU,CAAC,MAAM,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI;QAC7E,YAAY,EAAE,CAAC,OAAO,UAAU,CAAC,WAAW,KAAK,WAAW,IAAI,UAAU,CAAC,WAAW,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,YAAY,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI;QAC7L,YAAY,EAAE,CAAC,OAAO,UAAU,CAAC,WAAW,KAAK,WAAW,IAAI,UAAU,CAAC,WAAW,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,YAAY,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI;QAC7L,UAAU,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,UAAU,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;QAC9G,WAAW,EAAE,GAAG,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,KAAK,KAAK,WAAW,IAAI,UAAU,CAAC,KAAK,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,WAAW,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;KAC3M,CAAC;IAEF,OAAO,mBAAmB,CAAC;AAC/B,CAAC;AAzCD,4DAyCC"} \ No newline at end of file +{"version":3,"file":"VersionAdapter.js","sourceRoot":"","sources":["../../src/OpenViduInternal/VersionAdapter.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;GAeG;;AAGH,2DAA0D;AAE1D,yBAAgC,UAAkB,EAAE,iBAAmE,EAAE,OAAqB;IAE1I,IAAI,CAAC,CAAC,iBAAiB,EAAE;QACrB,OAAO,CAAC,IAAI,CAAC,wGAAwG,GAAG,UAAU,GAAG,oGAAoG,CAAC,CAAC;KAC9O;IAED,OAAO,IAAI,OAAO,CAAC,UAAC,OAAO,EAAE,MAAM;QAC/B,IAAI,CAAC,CAAC,iBAAiB,IAAI,OAAO,iBAAiB,KAAK,UAAU,EAAE;YAChE,OAAO,CAAC,IAAI,CAAC;gBACT,iBAAiB,CAAC,SAAS,CAAC,CAAC;YACjC,CAAC,CAAC,CAAC,OAAK,CAAA,CAAC,UAAA,KAAK;gBACV,iBAAiB,CAAC,KAAK,CAAC,CAAC;YAC7B,CAAC,CAAC,CAAC;SACN;aAAM;YACH,OAAO,CAAC,IAAI,CAAC;gBACT,OAAA,OAAO,EAAE;YAAT,CAAS,CACZ,CAAC,OAAK,CAAA,CAAC,UAAA,KAAK;gBACT,OAAA,MAAM,CAAC,KAAK,CAAC;YAAb,CAAa,CAChB,CAAC;SACL;IACL,CAAC,CAAC,CAAC;AACP,CAAC;AArBD,0CAqBC;AAED,kCAAyC,UAAe;IAEpD,IACI,OAAO,IAAI,UAAU;QACrB,OAAO,IAAI,UAAU;QACrB,aAAa,IAAI,UAAU;QAC3B,aAAa,IAAI,UAAU;QAC3B,SAAS,IAAI,UAAU;QACvB,QAAQ,IAAI,UAAU,EACxB;QACE,OAAO,CAAC,IAAI,CAAC,4NAA4N,CAAC,CAAC;KAC9O;IAED,IAAM,GAAG,GAAY,CAAC,OAAO,UAAU,CAAC,MAAM,KAAK,WAAW,IAAI,UAAU,CAAC,MAAM,KAAK,IAAI,CAAC,CAAC;IAC9F,IAAI,GAAG,GAAG,EAAE,CAAC;IACb,IAAI,OAAO,UAAU,CAAC,OAAO,KAAK,QAAQ,EAAE;QACxC,QAAQ,UAAU,CAAC,OAAO,EAAE;YACxB,KAAK,KAAK;gBACN,GAAG,GAAG,SAAS,CAAC;gBAChB,MAAM;YACV,KAAK,QAAQ;gBACT,GAAG,GAAG,SAAS,CAAC;gBAChB,MAAM;YACV,KAAK,MAAM;gBACP,GAAG,GAAG,UAAU,CAAC;gBACjB,MAAM;SACb;KACJ;IAED,IAAM,mBAAmB,GAAG;QACxB,WAAW,EAAE,CAAC,OAAO,UAAU,CAAC,KAAK,KAAK,WAAW,IAAI,UAAU,CAAC,KAAK,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,WAAW,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC,CAAC,SAAS,CAAC;QACrL,SAAS,EAAE,CAAC,OAAO,UAAU,CAAC,SAAS,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS;QAC3F,UAAU,EAAE,CAAC,OAAO,UAAU,CAAC,UAAU,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,CAAC,iCAAe,CAAC,MAAM;QAC3G,MAAM,EAAE,CAAC,OAAO,UAAU,CAAC,MAAM,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI;QAC7E,YAAY,EAAE,CAAC,OAAO,UAAU,CAAC,WAAW,KAAK,WAAW,IAAI,UAAU,CAAC,WAAW,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,YAAY,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI;QAC7L,YAAY,EAAE,CAAC,OAAO,UAAU,CAAC,WAAW,KAAK,WAAW,IAAI,UAAU,CAAC,WAAW,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,YAAY,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI;QAC7L,UAAU,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,UAAU,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;QAC9G,WAAW,EAAE,GAAG,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,KAAK,KAAK,WAAW,IAAI,UAAU,CAAC,KAAK,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,UAAU,CAAC,WAAW,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;KAC3M,CAAC;IAEF,OAAO,mBAAmB,CAAC;AAC/B,CAAC;AAzCD,4DAyCC"} \ No newline at end of file diff --git a/openvidu-browser/src/OpenViduInternal/VersionAdapter.ts b/openvidu-browser/src/OpenViduInternal/VersionAdapter.ts index 42a682d5..10e5fe4b 100644 --- a/openvidu-browser/src/OpenViduInternal/VersionAdapter.ts +++ b/openvidu-browser/src/OpenViduInternal/VersionAdapter.ts @@ -21,7 +21,7 @@ import { VideoInsertMode } from './Enums/VideoInsertMode'; export function solveIfCallback(methodName: string, completionHandler: ((error: Error | undefined) => void) | undefined, promise: Promise): Promise { if (!!completionHandler) { - console.warn("DEPRECATION WANING: In future releases the 'completionHandler' parameter will be removed from method '" + methodName + "'. Please, refactor your callbacks to Promise API"); + console.warn("DEPRECATION WANING: In future releases the 'completionHandler' parameter will be removed from method '" + methodName + "'. Refactor your callbacks to Promise API (see http://openvidu.io/api/openvidu-browser/index.html)"); } return new Promise((resolve, reject) => { @@ -51,7 +51,7 @@ export function adaptPublisherProperties(properties: any): PublisherProperties { 'quality' in properties || 'screen' in properties ) { - console.warn("DEPRECATION WANING: In future releases the properties passed to 'OpenVidu.initPublisher' method must match PublisherProperties interface. See http://openvidu.io"); + console.warn("DEPRECATION WANING: In future releases the properties passed to 'OpenVidu.initPublisher' method must match PublisherProperties interface (see http://openvidu.io/api/openvidu-browser/interfaces/publisherproperties.html)"); } const scr: boolean = (typeof properties.screen !== 'undefined' && properties.screen === true); diff --git a/openvidu-testapp/src/app/components/openvidu-instance/openvidu-instance.component.ts b/openvidu-testapp/src/app/components/openvidu-instance/openvidu-instance.component.ts index b6e0333b..c5aeb6ea 100644 --- a/openvidu-testapp/src/app/components/openvidu-instance/openvidu-instance.component.ts +++ b/openvidu-testapp/src/app/components/openvidu-instance/openvidu-instance.component.ts @@ -196,9 +196,8 @@ export class OpenviduInstanceComponent implements OnInit, OnChanges, OnDestroy { this.addSessionEvents(this.session); - this.session.connect(token, this.clientData, (error) => { - if (!error) { - + this.session.connect(token, this.clientData) + .then(() => { this.changeDetector.detectChanges(); if (this.publishTo) { @@ -215,12 +214,11 @@ export class OpenviduInstanceComponent implements OnInit, OnChanges, OnDestroy { // this.asyncInitPublisher(); this.syncInitPublisher(); - } - } else { + }) + .catch(error => { console.log('There was an error connecting to the session:', error.code, error.message); - } - }); + }); } @@ -406,13 +404,12 @@ export class OpenviduInstanceComponent implements OnInit, OnChanges, OnDestroy { data: 'Test message', to: [], type: 'chat' - }, - error => { - if (error) { - console.error(error); - } else { - console.log('Message succesfully sent'); - } + }) + .then(() => { + console.log('Message succesfully sent'); + }) + .catch(error => { + console.error(error); }); // this.initGrayVideo(); }