diff --git a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedQuickStartRecordingService.java b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedQuickStartRecordingService.java index 29c22dbb..7d1d0e87 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedQuickStartRecordingService.java +++ b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedQuickStartRecordingService.java @@ -220,7 +220,7 @@ public class ComposedQuickStartRecordingService extends ComposedRecordingService String containerId = null; try { - final String container = RecordingManager.IMAGE_NAME + ":" + RecordingManager.IMAGE_TAG; + final String container = RecordingManager.IMAGE_NAME + ":" + openviduConfig.getOpenViduRecordingVersion(); final String containerName = "recording_" + session.getSessionId(); Volume volume1 = new Volume("/recordings"); List volumes = new ArrayList<>(); diff --git a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java index e35a6bb8..31a55bad 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java +++ b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java @@ -166,7 +166,7 @@ public class ComposedRecordingService extends RecordingService { String containerId; try { - final String container = RecordingManager.IMAGE_NAME + ":" + RecordingManager.IMAGE_TAG; + final String container = RecordingManager.IMAGE_NAME + ":" + openviduConfig.getOpenViduRecordingVersion(); final String containerName = "recording_" + recording.getId(); Volume volume1 = new Volume("/recordings"); List volumes = new ArrayList<>(); diff --git a/openvidu-server/src/main/java/io/openvidu/server/recording/service/RecordingManager.java b/openvidu-server/src/main/java/io/openvidu/server/recording/service/RecordingManager.java index fc32b293..59161812 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/recording/service/RecordingManager.java +++ b/openvidu-server/src/main/java/io/openvidu/server/recording/service/RecordingManager.java @@ -126,7 +126,6 @@ public class RecordingManager { Runtime.getRuntime().availableProcessors()); public static final String IMAGE_NAME = "openvidu/openvidu-recording"; - public static String IMAGE_TAG; private static final List LAST_PARTICIPANT_LEFT_REASONS = Arrays .asList(new EndReason[] { EndReason.disconnect, EndReason.forceDisconnectByUser, @@ -166,8 +165,6 @@ public class RecordingManager { public void initializeRecordingManager() throws OpenViduException { - RecordingManager.IMAGE_TAG = openviduConfig.getOpenViduRecordingVersion(); - this.dockerManager.init(); this.composedRecordingService = new ComposedRecordingService(this, recordingDownloader, recordingUploader, @@ -223,7 +220,7 @@ public class RecordingManager { log.info("Recording module required: Downloading openvidu/openvidu-recording:" + openviduConfig.getOpenViduRecordingVersion() + " Docker image (350MB aprox)"); - if (dockMng.dockerImageExistsLocally(IMAGE_NAME + ":" + IMAGE_TAG)) { + if (dockMng.dockerImageExistsLocally(IMAGE_NAME + ":" + openviduConfig.getOpenViduRecordingVersion())) { log.info("Docker image already exists locally"); } else { Thread t = new Thread(() -> { @@ -241,9 +238,10 @@ public class RecordingManager { }); t.start(); try { - dockMng.downloadDockerImage(IMAGE_NAME + ":" + IMAGE_TAG, 600); + dockMng.downloadDockerImage(IMAGE_NAME + ":" + openviduConfig.getOpenViduRecordingVersion(), 600); } catch (Exception e) { - log.error("Error downloading docker image {}:{}", IMAGE_NAME, IMAGE_TAG); + log.error("Error downloading docker image {}:{}", IMAGE_NAME, + openviduConfig.getOpenViduRecordingVersion()); } t.interrupt(); try {