diff --git a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java index b1446ab9..41143ffb 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java +++ b/openvidu-server/src/main/java/io/openvidu/server/recording/service/ComposedRecordingService.java @@ -175,8 +175,7 @@ public class ComposedRecordingService extends RecordingService { List binds = new ArrayList<>(); binds.add(bind1); binds.add(bind2); - containerId = dockerManager.runContainer(container, containerName, volumes, binds, null, null, "host", - envs); + containerId = dockerManager.runContainer(container, containerName, volumes, binds, "host", envs); containers.put(containerId, containerName); } catch (Exception e) { this.cleanRecordingMaps(recording); diff --git a/openvidu-server/src/main/java/io/openvidu/server/utils/DockerManager.java b/openvidu-server/src/main/java/io/openvidu/server/utils/DockerManager.java index cab650f5..576bcaf1 100644 --- a/openvidu-server/src/main/java/io/openvidu/server/utils/DockerManager.java +++ b/openvidu-server/src/main/java/io/openvidu/server/utils/DockerManager.java @@ -38,11 +38,8 @@ import com.github.dockerjava.api.exception.InternalServerErrorException; import com.github.dockerjava.api.exception.NotFoundException; import com.github.dockerjava.api.model.Bind; import com.github.dockerjava.api.model.Container; -import com.github.dockerjava.api.model.ExposedPort; import com.github.dockerjava.api.model.Frame; import com.github.dockerjava.api.model.HostConfig; -import com.github.dockerjava.api.model.Ports; -import com.github.dockerjava.api.model.Ports.Binding; import com.github.dockerjava.api.model.Volume; import com.github.dockerjava.core.DefaultDockerClientConfig; import com.github.dockerjava.core.DockerClientBuilder; @@ -107,7 +104,7 @@ public class DockerManager { } public String runContainer(String container, String containerName, List volumes, List binds, - List exposedPorts, Ports portBindings, String networkMode, List envs) throws Exception { + String networkMode, List envs) throws Exception { CreateContainerCmd cmd = dockerClient.createContainerCmd(container).withEnv(envs); if (containerName != null) { @@ -121,17 +118,6 @@ public class DockerManager { if (binds != null) { hostConfig.withBinds(binds); } - if (exposedPorts != null) { - Ports symmetricPortBindings = new Ports(); - List expPorts = new ArrayList<>(); - exposedPorts.forEach(p -> { - ExposedPort port = ExposedPort.tcp(p); - expPorts.add(port); - symmetricPortBindings.bind(port, Binding.bindPort(p)); - }); - hostConfig.withPortBindings((portBindings == null) ? symmetricPortBindings : portBindings); - cmd.withExposedPorts(expPorts); - } cmd.withHostConfig(hostConfig);