From 17ec0c84515ddc77d96bd2e15a9a1b1b2183bd75 Mon Sep 17 00:00:00 2001 From: csantosm <4a.santos@gmail.com> Date: Tue, 13 Oct 2020 12:28:50 +0200 Subject: [PATCH] openvidu-browser: Added network quality Firefox support - Added basic version for Firefox. It does not support webrtc stats approach --- openvidu-browser/src/OpenVidu/Session.ts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/openvidu-browser/src/OpenVidu/Session.ts b/openvidu-browser/src/OpenVidu/Session.ts index 8ea22dfb..e424ea2d 100644 --- a/openvidu-browser/src/OpenVidu/Session.ts +++ b/openvidu-browser/src/OpenVidu/Session.ts @@ -1140,7 +1140,6 @@ export class Session extends EventDispatcher { setTimeout(async () => { const statsMap = await streamManager.stream.getWebRtcPeer().pc.getStats(); statsMap.forEach((stats) => { - if ("frameWidth" in stats) { this.openvidu.sendRequest('videoData', { height: stats.frameHeight, @@ -1155,6 +1154,18 @@ export class Session extends EventDispatcher { } }); }, intervalSeconds * 1000); + } else if (this.openvidu.isFirefoxBrowser() || this.openvidu.isFirefoxMobileBrowser()) { + // Basic version for Firefox. It does not support stats + this.openvidu.sendRequest('videoData', { + height: streamManager.stream.videoDimensions.height, + width: streamManager.stream.videoDimensions.width, + videoActive: streamManager.stream.videoActive, + audioActive: streamManager.stream.audioActive + }, (error, response) => { + if (error) { + logger.error("Error sending 'videoData' event", error); + } + }); } else { console.error('Browser ' + platform.name + ' (version ' + platform.version + ') for ' + platform.os!!.family + ' is not supported in OpenVidu for Network Quality'); }