ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #630 from pedro-sa-89/remove-console.error-poluting-console-output 

removed console.error() poluting console output on http failure
pull/634/head
Carlos Santos 2021-06-10 11:39:29 +02:00 committed by GitHub
parent 2fcf136fa3 2148b37974
commit 131d883299
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
openvidu-node-client/src/OpenVidu.ts
View File

@ -206,10 +206,10 @@ export class OpenVidu {
// The request was made but no response was received // The request was made but no response was received
// `error.request` is an instance of XMLHttpRequest in the browser and an instance of // `error.request` is an instance of XMLHttpRequest in the browser and an instance of
// http.ClientRequest in node.js // http.ClientRequest in node.js
console.error(error.request); reject(error.request);
} else { } else {
// Something happened in setting up the request that triggered an Error // Something happened in setting up the request that triggered an Error
console.error('Error', error.message); reject(error.message);
} }
}); });
}); });
@ -259,10 +259,10 @@ export class OpenVidu {
} else if (error.request) { } else if (error.request) {
// The request was made but no response was received `error.request` is an instance of XMLHttpRequest // The request was made but no response was received `error.request` is an instance of XMLHttpRequest
// in the browser and an instance of http.ClientRequest in node.js // in the browser and an instance of http.ClientRequest in node.js
console.error(error.request); reject(new Error(error.request));
} else { } else {
// Something happened in setting up the request that triggered an Error // Something happened in setting up the request that triggered an Error
console.error('Error', error.message); reject(new Error(error.message));
} }
}); });
}); });
@ -304,10 +304,10 @@ export class OpenVidu {
// The request was made but no response was received // The request was made but no response was received
// `error.request` is an instance of XMLHttpRequest in the browser and an instance of // `error.request` is an instance of XMLHttpRequest in the browser and an instance of
// http.ClientRequest in node.js // http.ClientRequest in node.js
console.error(error.request); reject(new Error(error.request));
} else { } else {
// Something happened in setting up the request that triggered an Error // Something happened in setting up the request that triggered an Error
console.error('Error', error.message); reject(new Error(error.message));
} }
}); });
}); });
@ -352,10 +352,10 @@ export class OpenVidu {
// The request was made but no response was received // The request was made but no response was received
// `error.request` is an instance of XMLHttpRequest in the browser and an instance of // `error.request` is an instance of XMLHttpRequest in the browser and an instance of
// http.ClientRequest in node.js // http.ClientRequest in node.js
console.error(error.request); reject(new Error(error.request));
} else { } else {
// Something happened in setting up the request that triggered an Error // Something happened in setting up the request that triggered an Error
console.error('Error', error.message); reject(new Error(error.message));
} }
}); });
}); });
@ -398,10 +398,10 @@ export class OpenVidu {
// The request was made but no response was received // The request was made but no response was received
// `error.request` is an instance of XMLHttpRequest in the browser and an instance of // `error.request` is an instance of XMLHttpRequest in the browser and an instance of
// http.ClientRequest in node.js // http.ClientRequest in node.js
console.error(error.request); reject(new Error(error.request));
} else { } else {
// Something happened in setting up the request that triggered an Error // Something happened in setting up the request that triggered an Error
console.error('Error', error.message); reject(new Error(error.message));
} }
}); });
}); });
@ -479,11 +479,9 @@ export class OpenVidu {
// The request was made but no response was received // The request was made but no response was received
// `error.request` is an instance of XMLHttpRequest in the browser and an instance of // `error.request` is an instance of XMLHttpRequest in the browser and an instance of
// http.ClientRequest in node.js // http.ClientRequest in node.js
console.error(error.request);
reject(error); reject(error);
} else { } else {
// Something happened in setting up the request that triggered an Error // Something happened in setting up the request that triggered an Error
console.error('Error', error.message);
reject(new Error(error.message)); reject(new Error(error.message));
} }
}); });
@ -649,10 +647,10 @@ export class OpenVidu {
// The request was made but no response was received // The request was made but no response was received
// `error.request` is an instance of XMLHttpRequest in the browser and an instance of // `error.request` is an instance of XMLHttpRequest in the browser and an instance of
// http.ClientRequest in node.js // http.ClientRequest in node.js
console.error(error.request); reject(new Error(error.request));
} else { } else {
// Something happened in setting up the request that triggered an Error // Something happened in setting up the request that triggered an Error
console.error('Error', error.message); reject(new Error(error.message));
} }
}); });
}); });
@ -668,7 +666,6 @@ export class OpenVidu {
try { try {
url = new URL(this.hostname); url = new URL(this.hostname);
} catch (error) { } catch (error) {
console.error('URL format incorrect', error);
throw new Error('URL format incorrect: ' + error); throw new Error('URL format incorrect: ' + error);
} }
this.host = url.protocol + '//' + url.host; this.host = url.protocol + '//' + url.host;

4
openvidu-node-client/src/Session.ts
View File

@ -511,11 +511,9 @@ export class Session {
// The request was made but no response was received // The request was made but no response was received
// `error.request` is an instance of XMLHttpRequest in the browser and an instance of // `error.request` is an instance of XMLHttpRequest in the browser and an instance of
// http.ClientRequest in node.js // http.ClientRequest in node.js
console.error(error.request);
reject(new Error(error.request)); reject(new Error(error.request));
} else { } else {
// Something happened in setting up the request that triggered an Error // Something happened in setting up the request that triggered an Error
console.error('Error', error.message);
reject(new Error(error.message)); reject(new Error(error.message));
} }
}); });
@ -642,11 +640,9 @@ export class Session {
// The request was made but no response was received // The request was made but no response was received
// `error.request` is an instance of XMLHttpRequest in the browser and an instance of // `error.request` is an instance of XMLHttpRequest in the browser and an instance of
// http.ClientRequest in node.js // http.ClientRequest in node.js
console.error(error.request);
reject(new Error(error.request)); reject(new Error(error.request));
} else { } else {
// Something happened in setting up the request that triggered an Error // Something happened in setting up the request that triggered an Error
console.error('Error', error.message);
reject(new Error(error.message)); reject(new Error(error.message));
} }
} }