ambiser
/
openvidu
mirror of https://github.com/OpenVidu/openvidu.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openvidu-browser: fix unexpected undefined exception on reconnected callback

pull/546/head
pabloFuente 2020-09-29 11:59:30 +02:00
parent a852a826fa
commit 12f215ddd9
2 changed files with 23 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openvidu-browser/src/OpenVidu/OpenVidu.ts
View File

@ -1025,6 +1025,7 @@ export class OpenVidu {
private reconnectedCallback(): void {
logger.warn('Websocket reconnected');
if (this.isRoomAvailable()) {
if (!!this.session.connection) {
this.sendRequest('connect', { sessionId: this.session.connection.rpcSessionId }, (error, response) => {
if (!!error) {
logger.error(error);
@ -1036,6 +1037,9 @@ export class OpenVidu {
this.session.onRecoveredConnection();
}
});
} else {
logger.warn('There was no previous connection when running reconnection callback');
}
} else {
alert('Connection error. Please reload page.');
}

2
openvidu-browser/src/OpenVidu/Session.ts
View File

@ -987,7 +987,7 @@ export class Session extends EventDispatcher {
*/
onLostConnection(reason: string): void {
logger.warn('Lost connection in Session ' + this.sessionId);
if (!!this.sessionId && !this.connection.disposed) {
if (!!this.sessionId && !!this.connection && !this.connection.disposed) {
this.leave(true, reason);
}
}