diff --git a/openvidu-java-client/src/main/java/io/openvidu/java/client/SessionProperties.java b/openvidu-java-client/src/main/java/io/openvidu/java/client/SessionProperties.java index 98ecebfb..44093f18 100644 --- a/openvidu-java-client/src/main/java/io/openvidu/java/client/SessionProperties.java +++ b/openvidu-java-client/src/main/java/io/openvidu/java/client/SessionProperties.java @@ -120,7 +120,8 @@ public class SessionProperties { * the specified codec and {@link #allowTranscoding(Boolean)} is * false and exception will occur. If forcedVideoCodec is set to * NONE, no codec will be forced.
- * Default value is {@link VideoCodec#VP8} + * If defined here, this parameter has prevalence over OPENVIDU_STREAMS_FORCED_VIDEO_CODEC. + * OPENVIDU_STREAMS_FORCED_VIDEO_CODEC default is {@link VideoCodec#VP8} */ public SessionProperties.Builder forcedVideoCodec(VideoCodec forcedVideoCodec) { this.forcedVideoCodec = forcedVideoCodec; @@ -131,7 +132,8 @@ public class SessionProperties { * Call this method to define if you want to allow transcoding in the media * server or not when {@link #forcedVideoCodec(VideoCodec)} is not compatible * with the browser/client.
- * Default value is false + * If defined here, this parameter has prevalence over OPENVIDU_STREAMS_ALLOW_TRANSCODING. + * OPENVIDU_STREAMS_ALLOW_TRANSCODING default is 'false' */ public SessionProperties.Builder allowTranscoding(Boolean allowTranscoding) { this.allowTranscoding = allowTranscoding; @@ -247,4 +249,4 @@ public class SessionProperties { return json; } -} \ No newline at end of file +} diff --git a/openvidu-node-client/src/Session.ts b/openvidu-node-client/src/Session.ts index 79d70843..f0baa2b7 100644 --- a/openvidu-node-client/src/Session.ts +++ b/openvidu-node-client/src/Session.ts @@ -656,8 +656,8 @@ export class Session { props.recordingMode = (props.recordingMode != null) ? props.recordingMode : RecordingMode.MANUAL; props.customSessionId = (props.customSessionId != null) ? props.customSessionId : ''; props.mediaNode = (props.mediaNode != null) ? props.mediaNode : undefined; - props.forcedVideoCodec = (props.forcedVideoCodec != null) ? props.forcedVideoCodec : VideoCodec.VP8; - props.allowTranscoding = (props.allowTranscoding != null) ? props.allowTranscoding : false; + props.forcedVideoCodec = props.forcedVideoCodec; + props.allowTranscoding = props.allowTranscoding; if (!props.defaultRecordingProperties) { props.defaultRecordingProperties = {}; @@ -695,4 +695,4 @@ export class Session { } } -} \ No newline at end of file +} diff --git a/openvidu-node-client/src/SessionProperties.ts b/openvidu-node-client/src/SessionProperties.ts index da7b09b1..fed08292 100644 --- a/openvidu-node-client/src/SessionProperties.ts +++ b/openvidu-node-client/src/SessionProperties.ts @@ -28,14 +28,14 @@ export interface SessionProperties { /** * How the media streams will be sent and received by your clients: routed through OpenVidu Media Node * (`MediaMode.ROUTED`) or attempting direct p2p connections (`MediaMode.RELAYED`, _not available yet_) - * + * * Default to [[MediaMode.ROUTED]] */ mediaMode?: MediaMode; /** * Whether the Session will be automatically recorded (`RecordingMode.ALWAYS`) or not (`RecordingMode.MANUAL`) - * + * * Default to [[RecordingMode.MANUAL]] */ recordingMode?: RecordingMode; @@ -43,7 +43,7 @@ export interface SessionProperties { /** * Default recording properties of this session. You can easily override this value later when starting a * [[Recording]] by providing new [[RecordingProperties]] - * + * * Default values defined in [[RecordingProperties]] class */ defaultRecordingProperties?: RecordingProperties; @@ -57,7 +57,7 @@ export interface SessionProperties { /** * **This feature is part of OpenVidu Pro tier** PRO - * + * * The Media Node where to host the session. The default option if this property is not defined is the less loaded * Media Node at the moment the first user joins the session. This object defines the following properties as Media Node selector: * - `id`: Media Node unique identifier @@ -71,16 +71,18 @@ export interface SessionProperties { * This allows browsers/clients to use the same codec avoiding transcoding in the media server. * If the browser/client is not compatible with the specified codec and [[allowTranscoding]] is false * and exception will occur. If forcedVideoCodec is set to [[VideoCodec.NONE]], no codec will be forced. - * - * Default to [[VideoCodec.VP8]] + * + * If defined here, this parameter has prevalence over OPENVIDU_STREAMS_FORCED_VIDEO_CODEC. + * OPENVIDU_STREAMS_FORCED_VIDEO_CODEC default is [[VideoCodec.VP8]] */ forcedVideoCodec?: VideoCodec; /** * It defines if you want to allow transcoding in the media server or not * when [[forcedVideoCodec]] is not compatible with the browser/client. - * - * Default to false + * + * If defined here, this parameter has prevalence over OPENVIDU_STREAMS_ALLOW_TRANSCODING. + * OPENVIDU_STREAMS_ALLOW_TRANSCODING default is 'false' */ allowTranscoding?: boolean;